* [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ?
@ 2014-11-17 17:15 dcb
2014-11-18 8:41 ` Amit Shah
2016-06-23 8:40 ` [Qemu-devel] [Bug 1393486] " T. Huth
0 siblings, 2 replies; 3+ messages in thread
From: dcb @ 2014-11-17 17:15 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
the left hand side of comparison [-Wlogical-not-parentheses]
if (!vrng->conf.period_ms > 0) {
error_setg(errp, "'period' parameter expects a positive integer");
return;
}
Maybe better code
if (vrng->conf.period_ms <= 0) {
error_setg(errp, "'period' parameter expects a positive integer");
return;
}
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1393486
Title:
hw/virtio/virtio-rng.c:150: bad test ?
Status in QEMU:
New
Bug description:
hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
the left hand side of comparison [-Wlogical-not-parentheses]
if (!vrng->conf.period_ms > 0) {
error_setg(errp, "'period' parameter expects a positive integer");
return;
}
Maybe better code
if (vrng->conf.period_ms <= 0) {
error_setg(errp, "'period' parameter expects a positive integer");
return;
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1393486/+subscriptions
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ? 2014-11-17 17:15 [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ? dcb @ 2014-11-18 8:41 ` Amit Shah 2016-06-23 8:40 ` [Qemu-devel] [Bug 1393486] " T. Huth 1 sibling, 0 replies; 3+ messages in thread From: Amit Shah @ 2014-11-18 8:41 UTC (permalink / raw) To: dcb; +Cc: qemu-devel On (Mon) 17 Nov 2014 [17:15:03], dcb wrote: > Public bug reported: > > hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to > the left hand side of comparison [-Wlogical-not-parentheses] > > if (!vrng->conf.period_ms > 0) { > error_setg(errp, "'period' parameter expects a positive integer"); > return; > } > > Maybe better code > > if (vrng->conf.period_ms <= 0) { > error_setg(errp, "'period' parameter expects a positive integer"); > return; > } Thanks! Do you want to submit a patch, since you've identified the fix as well? Amit ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [Bug 1393486] Re: hw/virtio/virtio-rng.c:150: bad test ? 2014-11-17 17:15 [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ? dcb 2014-11-18 8:41 ` Amit Shah @ 2016-06-23 8:40 ` T. Huth 1 sibling, 0 replies; 3+ messages in thread From: T. Huth @ 2016-06-23 8:40 UTC (permalink / raw) To: qemu-devel Fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a3a292c420d2fec3c07 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1393486 Title: hw/virtio/virtio-rng.c:150: bad test ? Status in QEMU: Fix Released Bug description: hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!vrng->conf.period_ms > 0) { error_setg(errp, "'period' parameter expects a positive integer"); return; } Maybe better code if (vrng->conf.period_ms <= 0) { error_setg(errp, "'period' parameter expects a positive integer"); return; } To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1393486/+subscriptions ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-23 8:46 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-17 17:15 [Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ? dcb 2014-11-18 8:41 ` Amit Shah 2016-06-23 8:40 ` [Qemu-devel] [Bug 1393486] " T. Huth
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).