From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Xqeot-0000NF-EH
	for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:11:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Xqeon-0002f1-9A
	for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:11:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58255)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Xqeon-0002ex-1v
	for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:11:25 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAI9BOqg017319
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 18 Nov 2014 04:11:24 -0500
Date: Tue, 18 Nov 2014 09:11:20 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20141118091119.GA448@work-vm>
References: <1415785203-26938-1-git-send-email-mst@redhat.com>
	<20141118090134.GB9190@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141118090134.GB9190@grmbl.mre>
Subject: Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

* Amit Shah (amit.shah@redhat.com) wrote:
> On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote:
> > This patchset fixes CVE-2014-7840: invalid
> > migration stream can cause arbitrary qemu memory
> > overwrite.
> > First patch includes the minimal fix for the issue.
> > Follow-up patches on top add extra checking to reduce the
> > chance this kind of bug recurs.
> > 
> > Note: these are already (tentatively-pending review)
> > queued in my tree, so only review/ack
> > is necessary.
> 
> Any more acks for this?  Dave?

Yep,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
(for the set)

> Also, Michael agreed to just push patch 1 for now, and 2-4 can go in
> later (2.3)?  Michael, is that fine with you?
> 
> 
> 		Amit

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK