From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqf9H-0005q5-Ol for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:32:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xqf9A-0001Mn-Mo for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:32:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqf9A-0001Mj-F3 for qemu-devel@nongnu.org; Tue, 18 Nov 2014 04:32:28 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAI9WRwF009151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 18 Nov 2014 04:32:27 -0500 Date: Tue, 18 Nov 2014 09:32:22 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141118093222.GB448@work-vm> References: <1415785203-26938-1-git-send-email-mst@redhat.com> <20141118090134.GB9190@grmbl.mre> <20141118092759.GA20230@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141118092759.GA20230@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Amit Shah , pbonzini@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com * Michael S. Tsirkin (mst@redhat.com) wrote: > On Tue, Nov 18, 2014 at 02:31:34PM +0530, Amit Shah wrote: > > On (Wed) 12 Nov 2014 [11:44:35], Michael S. Tsirkin wrote: > > > This patchset fixes CVE-2014-7840: invalid > > > migration stream can cause arbitrary qemu memory > > > overwrite. > > > First patch includes the minimal fix for the issue. > > > Follow-up patches on top add extra checking to reduce the > > > chance this kind of bug recurs. > > > > > > Note: these are already (tentatively-pending review) > > > queued in my tree, so only review/ack > > > is necessary. > > > > Any more acks for this? Dave? > > > > Also, Michael agreed to just push patch 1 for now, and 2-4 can go in > > later (2.3)? Michael, is that fine with you? > > > > > > Amit > > I'm fine with putting them off. > Someone wants to take them or should I? exec.c stuff seems to be pretty much all over, so I think you're as good as anyone. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK