From: Stefan Hajnoczi <stefanha@redhat.com>
To: Don Slutz <dslutz@verizon.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration
Date: Tue, 18 Nov 2014 11:37:21 +0000 [thread overview]
Message-ID: <20141118113721.GC9926@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1416259239-13281-1-git-send-email-dslutz@verizon.com>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Mon, Nov 17, 2014 at 04:20:39PM -0500, Don Slutz wrote:
> The other callers to blk_set_enable_write_cache() in this file
> already check for s->blk == NULL.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
>
> I think this is a bugfix that should be back ported to stable
> releases.
>
> I also think this should be done in xen's copy of QEMU for 4.5 with
> back port(s) to active stable releases.
>
> Note: In 2.1 and earlier the routine is
> bdrv_set_enable_write_cache(); variable is s->bs.
>
> hw/ide/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-18 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 21:20 [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration Don Slutz
2014-11-18 10:05 ` Paolo Bonzini
2014-11-18 11:37 ` Stefan Hajnoczi [this message]
2014-11-18 11:41 ` Kevin Wolf
2014-11-18 18:00 ` Peter Maydell
2014-11-18 14:12 ` Stefano Stabellini
2014-11-19 12:29 ` Markus Armbruster
2014-11-20 18:31 ` Don Slutz
2014-11-21 8:42 ` Markus Armbruster
2014-11-21 10:49 ` Dr. David Alan Gilbert
2014-11-25 0:48 ` Don Slutz
2014-11-25 8:59 ` Dr. David Alan Gilbert
2014-11-25 11:11 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118113721.GC9926@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=dslutz@verizon.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).