From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Xqh6E-0003in-Cr
	for qemu-devel@nongnu.org; Tue, 18 Nov 2014 06:37:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Xqh69-0008NI-O7
	for qemu-devel@nongnu.org; Tue, 18 Nov 2014 06:37:34 -0500
Date: Tue, 18 Nov 2014 11:37:21 +0000
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20141118113721.GC9926@stefanha-thinkpad.redhat.com>
References: <1416259239-13281-1-git-send-email-dslutz@verizon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="z4+8/lEcDcG5Ke9S"
Content-Disposition: inline
In-Reply-To: <1416259239-13281-1-git-send-email-dslutz@verizon.com>
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent
 SIGSEGV during migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org


--z4+8/lEcDcG5Ke9S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 17, 2014 at 04:20:39PM -0500, Don Slutz wrote:
> The other callers to blk_set_enable_write_cache() in this file
> already check for s->blk =3D=3D NULL.
>=20
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
>=20
> I think this is a bugfix that should be back ported to stable
> releases.
>=20
> I also think this should be done in xen's copy of QEMU for 4.5 with
> back port(s) to active stable releases.
>=20
> Note: In 2.1 and earlier the routine is
> bdrv_set_enable_write_cache(); variable is s->bs.
>=20
>  hw/ide/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--z4+8/lEcDcG5Ke9S
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUay9xAAoJEJykq7OBq3PIQwAH/17L6DjvhtMQ5IE+wQkEo9/u
nTN00mqaE/HO3Xkp44BdbJqYFcVfSgmd+IJqZEbo0A9AenYFHM4yYmDjIwoO/t0p
Mov/MNLP/CEvRMNYQ7icH5zS1X9hOpP/dq9GNLAr+xIQOVZsVcXC0NLcaueGySNP
x5JOF627D1lVeFMrW7qO/T20w5BRPFH3Rz+e7+MSxFbyiUZm7hUO1Ln7GXo+Hjqn
X8vwOMR+n3Au0FRNprNyT0Qtj9+OhAxX9WCeOhX4rrzRpICy9XfAKdoEDJngNlSx
4VpzY90FIFhKlojP+dIVLHZqYVECBunssOpkIPS5NAxnNwDmoKA4OXzYCntujMQ=
=rgBg
-----END PGP SIGNATURE-----

--z4+8/lEcDcG5Ke9S--