From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqi9Q-0006gK-PH for qemu-devel@nongnu.org; Tue, 18 Nov 2014 07:45:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xqi9M-00068m-3U for qemu-devel@nongnu.org; Tue, 18 Nov 2014 07:44:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xqi9L-00068R-TL for qemu-devel@nongnu.org; Tue, 18 Nov 2014 07:44:52 -0500 Date: Tue, 18 Nov 2014 13:44:41 +0100 From: Igor Mammedov Message-ID: <20141118134441.2f0711d0@nial.usersys.redhat.com> In-Reply-To: <1416200597-11925-2-git-send-email-tangchen@cn.fujitsu.com> References: <1416200597-11925-1-git-send-email-tangchen@cn.fujitsu.com> <1416200597-11925-2-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH Part1 1/5] acpi, pc: Add hotunplug request cb for pc machine. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tang Chen Cc: zhugh.fnst@cn.fujitsu.com, mst@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com, pbonzini@redhat.com On Mon, 17 Nov 2014 13:03:13 +0800 Tang Chen wrote: in subj s/cb/callback|handler/ > Memory and CPU hot unplug are both asynchronize procedures. s/asynchronize/asynchronous/ > They both need unplug request cb when the unplug operation happens. s/cb when the unplug operation happens/callback to initiate unplug operation/ > > This patch adds hotunplug request cb for pc machine, and memory and CPU > hot unplug will base on it. Add unplug handler to pc machine that will be used by following CPU and memory unplug patches. > > Signed-off-by: Tang Chen > --- > hw/i386/pc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 1205db8..5c48435 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1647,6 +1647,13 @@ static void pc_machine_device_plug_cb(HotplugHandler *hotplug_dev, > } > } > > +static void pc_machine_device_unplug_request_cb(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp) > +{ > + error_setg(errp, "acpi: device unplug request for not supported device" > + " type: %s", object_get_typename(OBJECT(dev))); it's not necessarily acpi related in general so maybe drop 'acpi:' prefix. Also it would be nice to add device's ID or use it instead of type name. > +} > + > static HotplugHandler *pc_get_hotpug_handler(MachineState *machine, > DeviceState *dev) > { > @@ -1753,6 +1760,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) > pcmc->get_hotplug_handler = mc->get_hotplug_handler; > mc->get_hotplug_handler = pc_get_hotpug_handler; > hc->plug = pc_machine_device_plug_cb; > + hc->unplug_request = pc_machine_device_unplug_request_cb; > } > > static const TypeInfo pc_machine_info = {