From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqjPC-0003Ga-Qq for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:05:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqjP6-000108-NC for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:05:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqjP6-0000zn-Gu for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:05:12 -0500 Date: Tue, 18 Nov 2014 14:05:07 +0000 From: Stefan Hajnoczi Message-ID: <20141118140507.GC7837@stefanha-thinkpad.redhat.com> References: <1414861350-13099-1-git-send-email-marc.mari.barcelo@gmail.com> <1414861350-13099-2-git-send-email-marc.mari.barcelo@gmail.com> <20141117151621.GF16192@stefanha-thinkpad.redhat.com> <20141117161905.2dc3eee0@crunchbang> <546A137E.2020202@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DSayHWYpDlRfCAAQ" Content-Disposition: inline In-Reply-To: <546A137E.2020202@suse.de> Subject: Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64_t in virtio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Marc =?iso-8859-1?Q?Mar=ED?= , Stefan Hajnoczi , qemu-devel@nongnu.org --DSayHWYpDlRfCAAQ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 17, 2014 at 04:25:50PM +0100, Andreas F=E4rber wrote: > Am 17.11.2014 um 16:19 schrieb Marc Mar=ED: > > El Mon, 17 Nov 2014 15:16:21 +0000 > > Stefan Hajnoczi escribi=F3: > >> On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Mar=ED wrote: > >>> Convert use of pointers in functions of virtio to uint64_t in order > >>> to make it platform-independent. > >>> > >>> Add casting from pointers (in PCI functions) to uint64_t and vice > >>> versa through uintptr_t. > >>> > >>> Signed-off-by: Marc Mar=ED > >>> --- > >>> tests/libqos/virtio-pci.c | 20 +++++++++++--------- > >>> tests/libqos/virtio.c | 8 ++++---- > >>> tests/libqos/virtio.h | 16 ++++++++-------- > >>> tests/virtio-blk-test.c | 21 ++++++++++++++------- > >>> 4 files changed, 37 insertions(+), 28 deletions(-) > >> > >> This makes sense. To fully abolish pointers the PCI code also needs > >> to be converted. Do plan plan to do that? > >> > >> Stefan > >=20 > > Not planned, but if asked, I may do it. >=20 > Pretty please. :) I was wondering the same thing when reading the patch. That said, you do not need to convert PCI in this patch series. If you do the PCI conversion in a separate patch series we can keep merging code incrementally. It's more satisfying for you that way and less intimidating for code reviews to review short series. Stefan --DSayHWYpDlRfCAAQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUa1ITAAoJEJykq7OBq3PI8UYH/3brbbaCGUVaeuAXBwTtZV/8 vavUmcOZwrGZ0f7LyclcQULQ8otu8jOeqZ12j9e7XxolTm8N3HWlAQp1RoeSm75e edxsyANwpEGLj8ZMQAWasjPHovJdQvfkZvgEecnt3PY5Rr/Ea5CAlH1a6O3tCzeA MwlMxVCLqP6bImyIZjHKdDoqGS5tqAZKYDnI98yNka8x+5PqDm1pDGHzeLZ64WoP cXIX/smkHC2XfhNhcnpqPcNDOTjGkIGWGkZAZ/GGbRzANG8u8shF8DbleokH4V35 MofB1IPT2p3x6Qot6+Rhb+7Do6AnW2qMcbDyT+ZaFXXpzFYI/7CaRIBW10Exf08= =tLyw -----END PGP SIGNATURE----- --DSayHWYpDlRfCAAQ--