From: Stefan Hajnoczi <stefanha@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
christoph.seifert@posteo.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces
Date: Tue, 18 Nov 2014 14:05:40 +0000 [thread overview]
Message-ID: <20141118140540.GD7837@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <87r3x12ruz.fsf@fimbulvetr.bsc.es>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On Mon, Nov 17, 2014 at 07:57:08PM -0600, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
>
> > On Sun, Nov 02, 2014 at 10:37:59PM +0100, christoph.seifert@posteo.de wrote:
> >> From: Christoph Seifert <christoph.seifert@posteo.de>
> >>
> >> simpletrace.py does not recognize the tcg option while reading trace-events
> >> file. In result simpletrace does not work on binary traces and tcg enabled
> >> events. Moved transformation of tcg enabled events to _read_events() which is
> >> used by simpletrace.
> >>
> >> Signed-off-by: Christoph Seifert <christoph.seifert@posteo.de>
> >> ---
> >> scripts/tracetool/__init__.py | 67 +++++++++++++++++++++----------------------
> >> 1 file changed, 33 insertions(+), 34 deletions(-)
>
> > Looks good to me.
>
> > Lluís: Any comments?
>
> I've looked at how it affects some patches I did not have time yet to send, and
> everything looks good.
Fantastic, thanks for your time, Lluís!
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-18 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 21:37 [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces christoph.seifert
2014-11-17 16:22 ` Stefan Hajnoczi
2014-11-18 1:57 ` Lluís Vilanova
2014-11-18 14:05 ` Stefan Hajnoczi [this message]
2014-11-18 14:07 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118140540.GD7837@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=christoph.seifert@posteo.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).