From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqjPj-0003a8-3x for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:05:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqjPe-00016k-Fo for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:05:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqjPd-00016V-Ud for qemu-devel@nongnu.org; Tue, 18 Nov 2014 09:05:46 -0500 Date: Tue, 18 Nov 2014 14:05:40 +0000 From: Stefan Hajnoczi Message-ID: <20141118140540.GD7837@stefanha-thinkpad.redhat.com> References: <1414964279-25288-1-git-send-email-christoph.seifert@posteo.de> <20141117162234.GJ16192@stefanha-thinkpad.redhat.com> <87r3x12ruz.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C1iGAkRnbeBonpVg" Content-Disposition: inline In-Reply-To: <87r3x12ruz.fsf@fimbulvetr.bsc.es> Subject: Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , christoph.seifert@posteo.de, qemu-devel@nongnu.org --C1iGAkRnbeBonpVg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 17, 2014 at 07:57:08PM -0600, Llu=EDs Vilanova wrote: > Stefan Hajnoczi writes: >=20 > > On Sun, Nov 02, 2014 at 10:37:59PM +0100, christoph.seifert@posteo.de w= rote: > >> From: Christoph Seifert > >>=20 > >> simpletrace.py does not recognize the tcg option while reading trace-e= vents > >> file. In result simpletrace does not work on binary traces and tcg ena= bled > >> events. Moved transformation of tcg enabled events to _read_events() w= hich is > >> used by simpletrace. > >>=20 > >> Signed-off-by: Christoph Seifert > >> --- > >> scripts/tracetool/__init__.py | 67 +++++++++++++++++++++--------------= -------- > >> 1 file changed, 33 insertions(+), 34 deletions(-) >=20 > > Looks good to me. >=20 > > Llu=EDs: Any comments? >=20 > I've looked at how it affects some patches I did not have time yet to sen= d, and > everything looks good. Fantastic, thanks for your time, Llu=EDs! Stefan --C1iGAkRnbeBonpVg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUa1I0AAoJEJykq7OBq3PI04YH/jQMBnaEnWJ9jG6XRqXjafP/ 3nlufB5Am70tcwfcRPtkLu711bpn4aCwxZYlJpY54ZZ0QiLuVgZjfxH8DnlfXedq cT7IYvXhBKj4YIFvb3SZwgyF29qLS+VTwzoMDQ4P3xFYs/hUcuvWhUpZ3g/uyfMQ cFP89csAHBDd9fLxF6nrqVjCVe+PTuPx7AdV8lkffVPCwx7rolfu6RbAzAXKkSWG HLI1BVn5n6r9ul9Bk75isAcQGCO6MeZAKUqfLZgXzg3+a0ZOyQ4KZDAZayIFYnXq 9zgXfaPHM5pbrbrZYuK+LgZllXUwyTLhqYivfqB32UbnRnpXYAOP4FgO2+Hnvtw= =FnKK -----END PGP SIGNATURE----- --C1iGAkRnbeBonpVg--