Re: [Qemu-devel] [PATCH] usb: delete redundant brackets in usb_host_handle_control()

[Fam Zheng <famz@redhat.com>]

On Wed, 11/19 14:57, Jun Li wrote:
> When see usb codes, find there are redundant brackets !((udev->port->speedmask
> & USB_SPEED_MASK_SUPER)) here. So delete it.
> 
> Signed-off-by: Jun Li <junmuzi@gmail.com>
> ---
>  hw/usb/host-libusb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index a5f9dab..cff4f7c 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -1237,7 +1237,7 @@ static void usb_host_handle_control(USBDevice *udev, USBPacket *p,
>      /* Fix up USB-3 ep0 maxpacket size to allow superspeed connected devices
>       * to work redirected to a not superspeed capable hcd */
>      if (udev->speed == USB_SPEED_SUPER &&
> -        !((udev->port->speedmask & USB_SPEED_MASK_SUPER)) &&
> +        !(udev->port->speedmask & USB_SPEED_MASK_SUPER) &&
>          request == 0x8006 && value == 0x100 && index == 0) {
>          r->usb3ep0quirk = true;
>      }
> -- 
> 1.9.3
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>

Cc'ing qemu-trivial@nongnu.org.

Fam