From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr29m-0000Gd-Ub for qemu-devel@nongnu.org; Wed, 19 Nov 2014 05:06:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xr29i-0000BL-41 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 05:06:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr29h-0000BE-SQ for qemu-devel@nongnu.org; Wed, 19 Nov 2014 05:06:34 -0500 Date: Wed, 19 Nov 2014 11:06:23 +0100 From: Igor Mammedov Message-ID: <20141119110623.6d5b804a@igors-macbook-pro.local> In-Reply-To: <546C5499.1000907@huawei.com> References: <1416201070-11448-1-git-send-email-zhang.zhanghailiang@huawei.com> <546C5499.1000907@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: peter.huangpeng@huawei.com, qemu-devel@nongnu.org, mst@redhat.com On Wed, 19 Nov 2014 16:28:09 +0800 zhanghailiang wrote: > Hi, > > Ping...? > > Should this be fixed in 2.2? I'd preffer it go after memory unplug is merged to see how balooning will fare along with it. Also ack from Luiz could be useful to make it sure that balloning will work just fine with sparse memory and memory unplug. > > Thanks, > zhanghailiang > On 2014/11/17 13:11, zhanghailiang wrote: > > Hi, > > > > Patch 1 and 2 mainly fix bug about balloon not working correctly > > when we do hotplug memory. It takes 'ram_size' as VM's real RAM > > size which is wrong after we hotplug memory. > > > > This bug exists since we begin to support hotplug memory, and it is > > better to fix it. > > > > Patch 3 add some trace events, it helps debugging balloon. If it is > > unnecessary, pls feel free to remove it. > > > > Thanks, > > zhanghailiang > > > > v2: > > - fix compiling break for other targets that don't support pc-dimm > > > > zhanghailiang (3): > > pc-dimm: add a function to calculate VM's current RAM size > > virtio-balloon: Fix balloon not working correctly when hotplug > > memory virtio-balloon: Add some trace events > > > > hw/mem/pc-dimm.c | 26 ++++++++++++++++++++++++++ > > hw/virtio/virtio-balloon.c | 21 +++++++++++++++------ > > include/exec/cpu-common.h | 1 + > > stubs/qmp_pc_dimm_device_list.c | 5 +++++ > > trace-events | 4 ++++ > > 5 files changed, 51 insertions(+), 6 deletions(-) > > > >