From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr60P-0004G9-Ve for qemu-devel@nongnu.org; Wed, 19 Nov 2014 09:13:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xr60I-0001QS-JK for qemu-devel@nongnu.org; Wed, 19 Nov 2014 09:13:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr60I-0001QK-B6 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 09:13:06 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAJED5ZC016843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 19 Nov 2014 09:13:05 -0500 Date: Wed, 19 Nov 2014 14:13:01 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141119141301.GC2355@work-vm> References: <546AE14E.7060606@redhat.com> <20141118074904.GA19745@redhat.com> <87y4r7o8dh.fsf@elfo.elfo> <20141119093320.GA26119@redhat.com> <87d28jo5yp.fsf@elfo.elfo> <20141119102136.GC26395@redhat.com> <878uj7o4ec.fsf@elfo.elfo> <20141119132851.GA27435@redhat.com> <546C9EC0.5000105@redhat.com> <87ioibmgx6.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ioibmgx6.fsf@elfo.elfo> Subject: Re: [Qemu-devel] [PATCH 2/5] exec: qemu_ram_alloc_device, qemu_ram_resize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Paolo Bonzini , qemu-devel@nongnu.org, "Michael S. Tsirkin" Since we've wondered off the actual ACPI table stuff into general ROM sizing, I'd like to propose some concrete fixes: 1) We explicitly name the bios file in a .romfile attribute for all ROMs. 2) The code that uses .romfile has an expansion for $MACHINETYPE 3) We actually symlink all of those together, anyone who wants/has to deal with different versions can downstream. 4) The machine types contain size attributes for the ROMs that are generoously larger than the ROMs anyone currently uses. I think 1..3 should deal with those of us who have to deal with different ROM versions on different machine types. 4 might be good enough for the ACPI tables if you can bound it. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK