From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrAQq-000744-5Y for qemu-devel@nongnu.org; Wed, 19 Nov 2014 13:56:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrAQm-0007jH-4z for qemu-devel@nongnu.org; Wed, 19 Nov 2014 13:56:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrAQl-0007j5-U8 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 13:56:44 -0500 Date: Wed, 19 Nov 2014 18:56:30 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141119185629.GQ2355@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-35-git-send-email-dgilbert@redhat.com> <20141110061031.GB31324@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141110061031.GB31324@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 34/47] Postcopy: Create a fault handler thread before marking the ram as userfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * David Gibson (david@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:40PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > This could do with a bit more rationale in the commit message. > > Also is there a reason not to fold this with the patch originally > marking the RAM as userfault? IIRC that one wasn't partocularly long > either. I've merged it with 'ram_enable_notify to switch on userfault' and it's commit message now reads. 'Mark the area of RAM as 'userfault' Start up a fault-thread to handle any userfaults we might receive from it (to be filled in later)' Dave > > Otherwise > > Reviewed-by: David Gibson > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK