From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrB4z-0003i9-R7 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 14:38:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrB4v-0007tv-P6 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 14:38:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrB4v-0007ti-I7 for qemu-devel@nongnu.org; Wed, 19 Nov 2014 14:38:13 -0500 Date: Wed, 19 Nov 2014 19:37:53 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141119193753.GS2355@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-37-git-send-email-dgilbert@redhat.com> <20141110063136.GD31324@voom.redhat.com> <20141117190732.GH11368@work-vm> <20141118043817.GF2867@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141118043817.GF2867@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page request List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * David Gibson (david@gibson.dropbear.id.au) wrote: > On Mon, Nov 17, 2014 at 07:07:33PM +0000, Dr. David Alan Gilbert wrote: > > > And maybe this one too - I would have expected the rb names to have > > > already been validated on the source machine at this stage. > > > > No to both: > > I've been trying to avoid asserts in migration outgoing code, because > > they shouldn't affect the state of your guest, so there's no reason > > to kill off what might still be a viable running guest just because > > migration failed. > > Ah, ok, that makes sense. Maybe adding something to the error message > or a nearby comment indicating that if these happen it's certainly a > bug, not the result of some external problem? Done. Dave > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK