From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrQG4-0004UI-Uk for qemu-devel@nongnu.org; Thu, 20 Nov 2014 06:50:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrQG0-0002W2-5c for qemu-devel@nongnu.org; Thu, 20 Nov 2014 06:50:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrQFz-0002Vu-Ub for qemu-devel@nongnu.org; Thu, 20 Nov 2014 06:50:40 -0500 Date: Thu, 20 Nov 2014 11:50:30 +0000 From: Stefan Hajnoczi Message-ID: <20141120115030.GD11224@stefanha-thinkpad.redhat.com> References: <1416463034-8264-1-git-send-email-arei.gonglei@huawei.com> <1416463034-8264-3-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FFoLq8A0u+X9iRU8" Content-Disposition: inline In-Reply-To: <1416463034-8264-3-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH 2/4] net/socket: fix Uninitialized scalar variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com --FFoLq8A0u+X9iRU8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 20, 2014 at 01:57:12PM +0800, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > If is_connected parameter is false, the saddr > variable will no initialize. Coverity report: > uninit_use: Using uninitialized value saddr.sin_port. >=20 > We don't need add saddr information to nc->info_str > when is_connected is false. >=20 > Signed-off-by: Gonglei > --- > net/socket.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi --FFoLq8A0u+X9iRU8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUbdWGAAoJEJykq7OBq3PI0wkH/2QrczdE6KDOdM+RLp2Jq5P5 wxHHWSbYdZHTBb7Cq3rHXCHe4hW7VAJlG1xmJEZUZdogTL/19AJLMexch6KhGPop RmIYpVBLc+S6YhYEnMwhU3eXEv4XRrJKF4jyZuuLbQD7NXPyVJHdi5WVM1O2GOUf IG+2tXTCjCI+UzEHoTZ+nxBVTJBstp9RLSiFGwgP4mFyVtDswgGRUiVowaOEWjnO Y5RjmLvDVd0o5NQjS3KgWbnoXWg5bml8O5mBh6t2ShGDDLcjH4NpeICFcaVlv9Sc EPccvCzsyBHRu4A5SxaoxFdD6twfw0bD31F+3q/shA0y+rikLKec31Q8Y8JOq6I= =nEFL -----END PGP SIGNATURE----- --FFoLq8A0u+X9iRU8--