From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: "chenliang (T)" <chenliang88@huawei.com>,
"quintela@redhat.com" <quintela@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Gonglei <arei.gonglei@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration
Date: Thu, 20 Nov 2014 12:35:54 +0000 [thread overview]
Message-ID: <20141120123553.GG5983@work-vm> (raw)
In-Reply-To: <20141120123056.GG9190@grmbl.mre>
* Amit Shah (amit.shah@redhat.com) wrote:
> On (Thu) 20 Nov 2014 [19:39:11], Gonglei wrote:
> > >>>> The static variables in migration_bitmap_sync will not be reset in
> > >>>> the case of a second attempted migration.
> > >>>>
> > >>>> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> > >>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > >>>
> > >>> Good catch. Applied..
> > >>>
> > >>
> > >> Hi, Juan? Ping... please :)
> > >
> > > Juan, what happened to this patch?
> >
> > Nearly for half a year, I forgot it completely :(
> > Thanks for your prompt, Paolo.
>
> Yeah; unfortunate.
>
> I feel the patch could've been done in a better way, but since it's
> been a while...
>
> Paolo, Dave, can you please give me r-b and I'll pick it up for 2.2.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Note that there are some more statics that have ended up in migration_bitmap_sync
since that patch landed, but still it would be good to get this fix going.
Dave
>
> Thanks,
>
> Amit
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-11-20 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 12:15 [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration arei.gonglei
2014-03-21 13:25 ` Juan Quintela
2014-03-21 13:25 ` Juan Quintela
2014-05-15 11:33 ` Gonglei (Arei)
2014-06-24 6:23 ` Gonglei (Arei)
2014-11-20 11:30 ` Paolo Bonzini
2014-11-20 11:39 ` Gonglei
2014-11-20 12:30 ` Amit Shah
2014-11-20 12:35 ` Dr. David Alan Gilbert [this message]
2014-11-20 13:00 ` Amit Shah
2014-11-20 13:05 ` Gonglei
2014-11-20 12:31 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120123553.GG5983@work-vm \
--to=dgilbert@redhat.com \
--cc=amit.shah@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=chenliang88@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).