From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrQxz-0001w7-O3 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 07:36:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrQxu-000279-Q6 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 07:36:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrQxu-00026w-Ij for qemu-devel@nongnu.org; Thu, 20 Nov 2014 07:36:02 -0500 Date: Thu, 20 Nov 2014 12:35:54 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141120123553.GG5983@work-vm> References: <1395317703-10412-1-git-send-email-arei.gonglei@huawei.com> <87vbv7heed.fsf@elfo.mitica> <33183CC9F5247A488A2544077AF1902086C1457B@SZXEMA503-MBS.china.huawei.com> <546DD0DB.4010607@redhat.com> <546DD2DF.4090005@huawei.com> <20141120123056.GG9190@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141120123056.GG9190@grmbl.mre> Subject: Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: "chenliang (T)" , "quintela@redhat.com" , "qemu-devel@nongnu.org" , Gonglei , Paolo Bonzini * Amit Shah (amit.shah@redhat.com) wrote: > On (Thu) 20 Nov 2014 [19:39:11], Gonglei wrote: > > >>>> The static variables in migration_bitmap_sync will not be reset in > > >>>> the case of a second attempted migration. > > >>>> > > >>>> Signed-off-by: ChenLiang > > >>>> Signed-off-by: Gonglei > > >>> > > >>> Good catch. Applied.. > > >>> > > >> > > >> Hi, Juan? Ping... please :) > > > > > > Juan, what happened to this patch? > > > > Nearly for half a year, I forgot it completely :( > > Thanks for your prompt, Paolo. > > Yeah; unfortunate. > > I feel the patch could've been done in a better way, but since it's > been a while... > > Paolo, Dave, can you please give me r-b and I'll pick it up for 2.2. Reviewed-by: Dr. David Alan Gilbert Note that there are some more statics that have ended up in migration_bitmap_sync since that patch landed, but still it would be good to get this fix going. Dave > > Thanks, > > Amit > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK