From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XrRLd-0005jx-I2
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 08:00:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XrRLY-00046z-Ju
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 08:00:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55718)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XrRLY-00046j-DM
	for qemu-devel@nongnu.org; Thu, 20 Nov 2014 08:00:28 -0500
Date: Thu, 20 Nov 2014 18:30:19 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20141120130019.GH9190@grmbl.mre>
References: <1395317703-10412-1-git-send-email-arei.gonglei@huawei.com>
	<87vbv7heed.fsf@elfo.mitica>
	<33183CC9F5247A488A2544077AF1902086C1457B@SZXEMA503-MBS.china.huawei.com>
	<546DD0DB.4010607@redhat.com> <546DD2DF.4090005@huawei.com>
	<20141120123056.GG9190@grmbl.mre> <20141120123553.GG5983@work-vm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141120123553.GG5983@work-vm>
Subject: Re: [Qemu-devel] [PATCH] migration: static variables will not be
 reset at second migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: "chenliang (T)" <chenliang88@huawei.com>, Gonglei <arei.gonglei@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, "quintela@redhat.com" <quintela@redhat.com>

On (Thu) 20 Nov 2014 [12:35:54], Dr. David Alan Gilbert wrote:
> * Amit Shah (amit.shah@redhat.com) wrote:
> > On (Thu) 20 Nov 2014 [19:39:11], Gonglei wrote:
> > > >>>> The static variables in migration_bitmap_sync will not be reset in
> > > >>>> the case of a second attempted migration.
> > > >>>>
> > > >>>> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> > > >>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > > >>>
> > > >>> Good catch.  Applied..
> > > >>>
> > > >>
> > > >> Hi, Juan? Ping... please :)
> > > > 
> > > > Juan, what happened to this patch?
> > >
> > > Nearly for half a year, I forgot it completely :(
> > > Thanks for your prompt, Paolo.
> > 
> > Yeah; unfortunate.
> > 
> > I feel the patch could've been done in a better way, but since it's
> > been a while...
> > 
> > Paolo, Dave, can you please give me r-b and I'll pick it up for 2.2.
> 
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Thanks; pull req sent.

		Amit