From: Kevin Wolf <kwolf@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Markus Armbruster <armbru@redhat.com>,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
Public KVM Mailing List <qemu-devel@nongnu.org>,
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>,
David Hildenbrand <dahi@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation
Date: Thu, 20 Nov 2014 17:18:30 +0100 [thread overview]
Message-ID: <20141120161830.GE9266@noname.redhat.com> (raw)
In-Reply-To: <20141119160406.7b8e0dbd.cornelia.huck@de.ibm.com>
Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben:
> On Wed, 19 Nov 2014 14:40:07 +0000
> Peter Maydell <peter.maydell@linaro.org> wrote:
>
> > On 19 November 2014 14:01, Ekaterina Tumanova
> > <tumanova@linux.vnet.ibm.com> wrote:
> > > Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
> >
> > Could you give the compiler error/warning message, please
> > (and the compiler version)?
> >
> > These changes look sensible but it's not clear to me why
> > the current code would cause a compilation failure or why
> > that would be specific to i386...
>
> This patch is referring to Kate's patch set "[PATCH v2 0/6] Geometry
> and blocksize support for backing devices", which did not compile on
> i386 (see <546C8161.10100@de.ibm.com>).
Where does it need to be squashed in? We want to keep the tree
bisectable, so breaking the build and then fixing it at the end of the
series isn't an option.
Kevin
next prev parent reply other threads:[~2014-11-20 16:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 10:17 [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices Ekaterina Tumanova
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize Ekaterina Tumanova
2014-11-21 10:01 ` Christian Borntraeger
2014-11-27 14:55 ` Markus Armbruster
2014-11-27 16:05 ` Ekaterina Tumanova
2014-11-28 8:25 ` Markus Armbruster
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions Ekaterina Tumanova
2014-11-21 10:17 ` Christian Borntraeger
2014-11-25 11:09 ` Stefan Hajnoczi
2014-11-27 17:41 ` Markus Armbruster
2014-11-28 10:58 ` Ekaterina Tumanova
2014-11-28 12:52 ` Markus Armbruster
2014-11-28 13:28 ` Ekaterina Tumanova
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry Ekaterina Tumanova
2014-11-21 13:52 ` Christian Borntraeger
2014-11-28 8:43 ` Markus Armbruster
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing Ekaterina Tumanova
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize Ekaterina Tumanova
2014-11-28 10:10 ` Markus Armbruster
2014-11-28 10:54 ` Ekaterina Tumanova
2014-11-28 12:58 ` Markus Armbruster
2014-11-28 10:27 ` Markus Armbruster
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing Ekaterina Tumanova
2014-11-28 10:47 ` Markus Armbruster
2014-11-19 11:39 ` [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices Christian Borntraeger
2014-11-19 14:01 ` [Qemu-devel] [PATCH] geometry: fix i386 compilation Ekaterina Tumanova
2014-11-19 14:40 ` Peter Maydell
2014-11-19 15:04 ` Cornelia Huck
2014-11-20 16:18 ` Kevin Wolf [this message]
2014-11-20 16:30 ` Christian Borntraeger
2014-11-21 9:42 ` Ekaterina Tumanova
2014-11-28 10:47 ` Markus Armbruster
2014-11-21 14:01 ` [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices Christian Borntraeger
2014-11-25 13:01 ` Stefan Hajnoczi
2014-11-26 10:16 ` Ekaterina Tumanova
2014-11-28 10:35 ` Stefan Hajnoczi
2014-11-28 11:15 ` Ekaterina Tumanova
2014-11-28 13:40 ` Markus Armbruster
2014-11-28 10:40 ` Stefan Hajnoczi
2014-11-28 10:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120161830.GE9266@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).