From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrUbn-0002ry-3d for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:29:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrUbg-0004EQ-Vc for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:29:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrUbg-0004EA-Oz for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:29:20 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKGTKMr000824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 11:29:20 -0500 Date: Thu, 20 Nov 2014 17:29:17 +0100 From: Kevin Wolf Message-ID: <20141120162917.GF9266@noname.redhat.com> References: <1416497234-29880-1-git-send-email-kwolf@redhat.com> <1416497234-29880-10-git-send-email-kwolf@redhat.com> <546E145A.5080603@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546E145A.5080603@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 9/9] qemu-iotests: Test writing non-raw image headers to raw image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com Am 20.11.2014 um 17:18 hat Max Reitz geschrieben: > On 2014-11-20 at 16:27, Kevin Wolf wrote: > >This is forbidden if the raw driver was probed. > > > >Signed-off-by: Kevin Wolf > >--- > > tests/qemu-iotests/109 | 132 +++++++++++++ > > tests/qemu-iotests/109.out | 231 ++++++++++++++++++++++ > > tests/qemu-iotests/group | 1 + > > tests/qemu-iotests/sample_images/grub_mbr.raw.bz2 | Bin 0 -> 552 bytes > > 4 files changed, 364 insertions(+) > > create mode 100755 tests/qemu-iotests/109 > > create mode 100644 tests/qemu-iotests/109.out > > create mode 100644 tests/qemu-iotests/sample_images/grub_mbr.raw.bz2 > > Looking at the hexdump of the grub_mbr.raw, it looks like GRUB 2 to > me (when comparing it to my MBR and a GRUB Legacy boot sector; I > wasn't so sure whether you might go for GRUB Legacy as a late > protest against GRUB 2). Good. :-) I don't care about the bad usability of a bootloader when I only put some part of it in an MBR image that won't boot anyway. ;-) My only form of protest is that if I nowadays want to write a bootloader to a disk image from the host, it's syslinux and not GRUB any more. It's not quite as nice, but at least installing that one is possible without damage to your sanity... Kevin