From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrV8B-0007c7-9H for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:03:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrV85-0007Yo-68 for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:02:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrV84-0007YQ-UX for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:02:49 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKH2mTm026670 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 12:02:48 -0500 Date: Thu, 20 Nov 2014 18:02:45 +0100 From: Kevin Wolf Message-ID: <20141120170245.GH9266@noname.redhat.com> References: <1416227466-29491-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416227466-29491-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi Am 17.11.2014 um 13:31 hat Max Reitz geschrieben: > This series does not add new functionality. Adding a QMP monitor with > prettily formatted JSON output can be done as follows: > > $ qemu -chardev stdio,id=mon0 -mon chardev=mon0,mode=control,pretty=on > > However, this is rather cumbersome, so this series (its first patch) > adds a shortcut in the form of the new command line option -qmp-pretty. > > Since the argument given to a monitor command line option (such as -qmp) > is parsed depending on its prefix and probably also depending on the > current phase of the moon, this is cleaner than trying to add a "switch" > to -qmp itself (in the form of "-qmp stdio,pretty=on"). > > > Patch 3 makes uses of the new option in qemu-iotest 067 to greatly > increase maintainability of its reference output. Patch 2 extends the > QMP filter for qemu-iotests so it is able to filter out the QMP version > object in pretty mode. Thanks, applied to block-next. Kevin