From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrjgi-000184-SX for qemu-devel@nongnu.org; Fri, 21 Nov 2014 03:35:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xrjge-0001Hu-QG for qemu-devel@nongnu.org; Fri, 21 Nov 2014 03:35:32 -0500 Received: from ozlabs.org ([103.22.144.67]:35798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrjge-0001HD-Fc for qemu-devel@nongnu.org; Fri, 21 Nov 2014 03:35:28 -0500 Date: Fri, 21 Nov 2014 19:36:44 +1100 From: David Gibson Message-ID: <20141121083644.GB11025@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-46-git-send-email-dgilbert@redhat.com> <20141113032915.GG7291@voom.fritz.box> <20141119194019.GT2355@work-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="98e8jtXdkpgskNou" Content-Disposition: inline In-Reply-To: <20141119194019.GT2355@work-vm> Subject: Re: [Qemu-devel] [PATCH v4 45/47] Start up a postcopy/listener thread ready for incoming page data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --98e8jtXdkpgskNou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 19, 2014 at 07:40:20PM +0000, Dr. David Alan Gilbert wrote: > * David Gibson (david@gibson.dropbear.id.au) wrote: > > On Fri, Oct 03, 2014 at 06:47:51PM +0100, Dr. David Alan Gilbert (git) = wrote: > > > From: "Dr. David Alan Gilbert" > > >=20 > > > The loading of a device state (during postcopy) may access guest > > > memory that's still on the source machine and thus might need > > > a page fill; split off a separate thread that handles the incoming > > > page data so that the original incoming migration code can finish > > > off the device data. > > >=20 > > > Signed-off-by: Dr. David Alan Gilbert > > > --- > > > include/migration/migration.h | 4 +++ > > > migration.c | 6 +++++ > > > savevm.c | 62 +++++++++++++++++++++++++++++++++= ++++++++-- > > > 3 files changed, 70 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/include/migration/migration.h b/include/migration/migrat= ion.h > > > index 00255b8..69e776c 100644 > > > --- a/include/migration/migration.h > > > +++ b/include/migration/migration.h > > > @@ -92,6 +92,10 @@ struct MigrationIncomingState { > > > QemuThread fault_thread; > > > QemuSemaphore fault_thread_sem; > > > =20 > > > + bool have_listen_thread; > >=20 > > AFAICT have_listen_thread is never set to a value other than 'true', > > so there doesn't see much point to it. >=20 > It's tested by qemu_loadvm_state to avoid doing cleaning stuff up as it e= xits, > since the listen thread is still using it. Right, but I couldn't see under what circumstances it would ever be false at the test false in qemu_loadvm_state(). --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --98e8jtXdkpgskNou Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUbvmcAAoJEGw4ysog2bOSCNoQALJ4IDSecY6+ZNczNk5iuKxW p0OGgowUMFazZMMyxjD2WiSWR1tl8UnPTFOzfhaEuO2XvNmg84a/35d6n3yi7Hil fG81vtWcq5CTSsFfcLFW3/BMhJfz0rySuZZjLLqiKWqaIIvxSfOCZLQ1BX8ZYaIx b8k/6ZsV9ObPT46AQ5aT1GsBqW5Ya8MHFNTrhY0QroJy0F+0NGREY2Bew6rucR6n 77k+iXGIrgwjlfr7r0EIQ5caj2qvHMX55lldwCGuWIl4svLU0q2rP3/mIclyrf63 fqFgf6z0oPlBkPB6Mxa14L5WbcDIN4ZbLO0zOwYWh52eahT98JWtOOAIDG9+nq4x FRMHofaaSl3B4W5qhJSaZrpq2uN027+qkkfu5rloTdLoKunoQrkiYo6YdcEKFj3N t402g4wwNZokcixp9M9+DFhmPsKPgeCGXC1iQ/DucCfXkW/Cly3eS1fx2lYuQbXb +xhGsvmKYhOIL2im26gUEqUlQT2IECuEDArMvawAfUo0t/Vgcun0NUIiB5tshTcI swHQZb4g8+DpMaQAH66xQ6teGx+xZCef6AVA/cHDoor2o/awbWeBuOvzmWBIkSbM 6eM1rZTVI0/mqN0PApTTGDF4XIOzihd8KrfpjliiOyd14ChWxyjLotgehRDQNdhv LSOvBQfHWc6ZeGpjp+S+ =NTv+ -----END PGP SIGNATURE----- --98e8jtXdkpgskNou--