From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qjson: Drop trailing space for pretty formatting
Date: Fri, 21 Nov 2014 13:36:29 +0100 [thread overview]
Message-ID: <20141121123629.GC3956@noname.redhat.com> (raw)
In-Reply-To: <1416562199-13731-1-git-send-email-mreitz@redhat.com>
Am 21.11.2014 um 10:29 hat Max Reitz geschrieben:
> For the pretty formatting, the functions converting QDicts and QLists to
> JSON should not print a space after the comma separating objects,
> because a newline will emitted immediately afterwards, making the
> whitespace superfluous.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Luiz, any objections?
/me waits a bit... 3... 2... 1...
No? Great, thanks, applied to block-next.
(More seriously, I have a patch with a qemu-iotests case depending on
the output, so I'm merging this before my patch. If there is a problem,
there's still some time until block-next ends up in master, so I can
always drop it or replace it with a v2.)
Kevin
next prev parent reply other threads:[~2014-11-21 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 9:29 [Qemu-devel] [PATCH] qjson: Drop trailing space for pretty formatting Max Reitz
2014-11-21 12:36 ` Kevin Wolf [this message]
2014-11-21 16:07 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121123629.GC3956@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).