Re: [Qemu-devel] [PATCH 0/3] apic: ExtINT fixes for QNX

Re: [Qemu-devel] [PATCH 0/3] apic: ExtINT fixes for QNX

[Richard Bilson]

[-- Attachment #1: Type: text/plain, Size: 1996 bytes --]

The one failure turns out to be an intermittent failure that has nothing to do with the patch and probably nothing to do with qemu at all. So I heartily approve of these patches.

Thanks very much, Paolo, for taking the time to implement these fixes.

From: Richard Bilson <rbilson@qnx.com<mailto:rbilson@qnx.com>>
Date: Fri Nov 14 2014 12:53:49 GMT-0500 (EST)
To: Paolo Bonzini <pbonzini@redhat.com<mailto:pbonzini@redhat.com>>, qemu-devel@nongnu.org <qemu-devel@nongnu.org<mailto:qemu-devel@nongnu.org>>
Subject: Re: [PATCH 0/3] apic: ExtINT fixes for QNX

I've been testing these against our entire kernel regression suite. While they definitely fix the original problems, there is one test that now hangs. I'm going to have to get to the bottom of that failure before I can sign off.

___________________​____________________​____________________​_____________
From: Paolo Bonzini <pbonzini@redhat.com<mailto:pbonzini@redhat.com>>
Date: Tue Nov 11 2014 09:23:38 GMT-0500 (EST)
To: qemu-devel@nongnu.org <qemu-devel@nongnu.org<mailto:qemu-devel@nongnu.org>>
Cc: Richard Bilson <rbilson@qnx.com<mailto:rbilson@qnx.com>>
Subject: [PATCH 0/3] apic: ExtINT fixes for QNX

Richard Bilson reported some QNX emulation bugs. I sent him offlist a prototype patch, that he commented on.

The first patch here works around what is arguably a QNX bug, that is
triggered by the last two patches; but it is better to avoid spurious
HLT wakeups, so here it is. The last two patches are what Richard
had tested, amended with a fix for Windows XP + KVM + QEMU apic.

Richard, can you confirm that these patches work?

Paolo

Paolo Bonzini (3):
apic: avoid getting out of halted state on masked PIC interrupts
apic: fix loss of IPI due to masked ExtINT
apic: fix incorrect handling of ExtINT interrupts wrt processor
priority

hw/intc/apic.c | 20 ++++++++++++--------
target-i386/cpu.c | 8 ++++++--
2 files changed, 18 insertions(+), 10 deletions(-)

--
2.1.0



[-- Attachment #2: Type: text/html, Size: 3833 bytes --]

Re: [Qemu-devel] [PATCH 0/3] apic: ExtINT fixes for QNX

[Richard Bilson]

[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]

I've been testing these against our entire kernel regression suite. While they definitely fix the original problems, there is one test that now hangs. I'm going to have to get to the bottom of that failure before I can sign off.

________________________________________________________________________
From: Paolo Bonzini <pbonzini@redhat.com<mailto:pbonzini@redhat.com>>
Date: Tue Nov 11 2014 09:23:38 GMT-0500 (EST)
To: qemu-devel@nongnu.org <qemu-devel@nongnu.org<mailto:qemu-devel@nongnu.org>>
Cc: Richard Bilson <rbilson@qnx.com<mailto:rbilson@qnx.com>>
Subject: [PATCH 0/3] apic: ExtINT fixes for QNX

Richard Bilson reported some QNX emulation bugs. I sent him offlist a prototype patch, that he commented on.

The first patch here works around what is arguably a QNX bug, that is
triggered by the last two patches; but it is better to avoid spurious
HLT wakeups, so here it is. The last two patches are what Richard
had tested, amended with a fix for Windows XP + KVM + QEMU apic.

Richard, can you confirm that these patches work?

Paolo

Paolo Bonzini (3):
apic: avoid getting out of halted state on masked PIC interrupts
apic: fix loss of IPI due to masked ExtINT
apic: fix incorrect handling of ExtINT interrupts wrt processor
priority

hw/intc/apic.c | 20 ++++++++++++--------
target-i386/cpu.c | 8 ++++++--
2 files changed, 18 insertions(+), 10 deletions(-)

--
2.1.0



[-- Attachment #2: Type: text/html, Size: 2606 bytes --]

[Qemu-devel] [PATCH 0/3] apic: ExtINT fixes for QNX

[Paolo Bonzini]

Richard Bilson reported some QNX emulation bugs.  I sent him offlist a
prototype patch, that he commented on.

The first patch here works around what is arguably a QNX bug, that is
triggered by the last two patches; but it is better to avoid spurious
HLT wakeups, so here it is.  The last two patches are what Richard
had tested, amended with a fix for Windows XP + KVM + QEMU apic.

Richard, can you confirm that these patches work?

Paolo

Paolo Bonzini (3):
  apic: avoid getting out of halted state on masked PIC interrupts
  apic: fix loss of IPI due to masked ExtINT
  apic: fix incorrect handling of ExtINT interrupts wrt processor
    priority

 hw/intc/apic.c    | 20 ++++++++++++--------
 target-i386/cpu.c |  8 ++++++--
 2 files changed, 18 insertions(+), 10 deletions(-)

-- 
2.1.0