From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsW12-0006ty-R9 for qemu-devel@nongnu.org; Sun, 23 Nov 2014 07:11:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XsW0w-000498-KJ for qemu-devel@nongnu.org; Sun, 23 Nov 2014 07:11:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsW0w-00048y-Bu for qemu-devel@nongnu.org; Sun, 23 Nov 2014 07:11:38 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sANCBb0v008933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 23 Nov 2014 07:11:37 -0500 Date: Sun, 23 Nov 2014 14:11:34 +0200 From: "Michael S. Tsirkin" Message-ID: <20141123121134.GA3474@redhat.com> References: <1414487352-6027-1-git-send-email-kraxel@redhat.com> <1414487352-6027-3-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414487352-6027-3-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] vga: flip qemu 2.2 pc machine types from cirrus to stdvga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: ajax@redhat.com, qemu-devel@nongnu.org On Tue, Oct 28, 2014 at 10:09:12AM +0100, Gerd Hoffmann wrote: > This patch switches the default display from cirrus to vga > for the new (qemu 2.2+) machine types. Old machines types > stay as-is for compatibility reasons. > > Signed-off-by: Gerd Hoffmann Gerd, I noticed that this caused a regression: suspend no longer works with windows, the option to suspend is greyed out. This is not new - it was disabled with -vga std previously - but poses a bigger problem now it's the default? Thoughts? Something we can fix for 2.2? > --- > hw/i386/pc_piix.c | 7 +++++-- > hw/i386/pc_q35.c | 7 +++++-- > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 91a20cb..8637246 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -456,7 +456,8 @@ static void pc_xen_hvm_init(MachineState *machine) > > #define PC_I440FX_2_2_MACHINE_OPTIONS \ > PC_I440FX_MACHINE_OPTIONS, \ > - .default_machine_opts = "firmware=bios-256k.bin" > + .default_machine_opts = "firmware=bios-256k.bin", \ > + .default_display = "std" > > static QEMUMachine pc_i440fx_machine_v2_2 = { > PC_I440FX_2_2_MACHINE_OPTIONS, > @@ -466,7 +467,9 @@ static QEMUMachine pc_i440fx_machine_v2_2 = { > .is_default = 1, > }; > > -#define PC_I440FX_2_1_MACHINE_OPTIONS PC_I440FX_2_2_MACHINE_OPTIONS > +#define PC_I440FX_2_1_MACHINE_OPTIONS \ > + PC_I440FX_MACHINE_OPTIONS, \ > + .default_machine_opts = "firmware=bios-256k.bin" > > static QEMUMachine pc_i440fx_machine_v2_1 = { > PC_I440FX_2_1_MACHINE_OPTIONS, > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index e225c6d..9fdb3fa 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -353,7 +353,8 @@ static void pc_q35_init_1_4(MachineState *machine) > > #define PC_Q35_2_2_MACHINE_OPTIONS \ > PC_Q35_MACHINE_OPTIONS, \ > - .default_machine_opts = "firmware=bios-256k.bin" > + .default_machine_opts = "firmware=bios-256k.bin", \ > + .default_display = "std" > > static QEMUMachine pc_q35_machine_v2_2 = { > PC_Q35_2_2_MACHINE_OPTIONS, > @@ -362,7 +363,9 @@ static QEMUMachine pc_q35_machine_v2_2 = { > .init = pc_q35_init, > }; > > -#define PC_Q35_2_1_MACHINE_OPTIONS PC_Q35_2_2_MACHINE_OPTIONS > +#define PC_Q35_2_1_MACHINE_OPTIONS \ > + PC_Q35_MACHINE_OPTIONS, \ > + .default_machine_opts = "firmware=bios-256k.bin" > > static QEMUMachine pc_q35_machine_v2_1 = { > PC_Q35_2_1_MACHINE_OPTIONS, > -- > 1.8.3.1