From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XssLf-0001rq-AD for qemu-devel@nongnu.org; Mon, 24 Nov 2014 07:02:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XssLY-0000EM-Ix for qemu-devel@nongnu.org; Mon, 24 Nov 2014 07:02:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XssLY-0000E5-9c for qemu-devel@nongnu.org; Mon, 24 Nov 2014 07:02:24 -0500 Date: Mon, 24 Nov 2014 12:02:19 +0000 From: Stefan Hajnoczi Message-ID: <20141124120219.GF4596@stefanha-thinkpad.redhat.com> References: <1416589530-10264-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7cm2iqirTL37Ot+N" Content-Disposition: inline In-Reply-To: <1416589530-10264-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: cyliu@suse.com, qemu-devel@nongnu.org, mreitz@redhat.com --7cm2iqirTL37Ot+N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 21, 2014 at 06:05:30PM +0100, Kevin Wolf wrote: > This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622. >=20 > The main reason for reverting this commit before the 2.2 release is that > it adds a QAPI interface that we don't want to keep: The 'nocow' flag > doesn't generally make sense for block nodes, but only for the raw-posix > driver. It should therefore be part of ImageInfoSpecific rather than > ImageInfo. >=20 > The commit contains more problems, but unlike the API stability issue > they wouldn't justify reverting it. >=20 > Conflicts: > block/qapi.c >=20 > Signed-off-by: Kevin Wolf > --- > block/qapi.c | 26 -------------------------- > qapi/block-core.json | 5 +---- > 2 files changed, 1 insertion(+), 30 deletions(-) Sorry for merging this prematurely, I agree with your points. Reviewed-by: Stefan Hajnoczi --7cm2iqirTL37Ot+N Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUcx5LAAoJEJykq7OBq3PIxmIIAIKqZxc9diXdNYodCemG2W+1 KBzQq6sZHLHzNtGUgkBhh0R3FDnxCNXYT5FMigvwgvvGODm9teagNhMuKHNFo9Ur tOXBw5YMolh/7n4PDrrIPeKMv7J0W05aBNmRcbM+3ZJXDlojo36bcbsaaDbC4JKS +gP0o2toB9av9fMISTKaWQw4PgUkXLldm8z6IRuYM0rre2wxGECT5/l8VaRxcj4L VxdyqYcQuVavpovmBGkwtwHnVe3aNkzQmKwP8sIVqMMHbQjpXGdq36IvSJBckXyT XouukPFYXDh/y/9zOnVfs7BgXk/n83lUOk7PqdHlBmjonQOWhyN6Qe405iw0xS4= =ESA7 -----END PGP SIGNATURE----- --7cm2iqirTL37Ot+N--