From: Stefan Hajnoczi <stefanha@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch
Date: Mon, 24 Nov 2014 16:40:23 +0000 [thread overview]
Message-ID: <20141124164023.GA14760@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1416839379-19677-2-git-send-email-ming.lei@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
On Mon, Nov 24, 2014 at 10:29:37PM +0800, Ming Lei wrote:
> + /* submit immediately if queue depth is above 2/3 */
> + if (idx > s->io_q.size * 2 / 3) {
> + return ioq_submit(s);
The return value of ioq_submit() is the number of requests submitted (0
or more). This has no meaning to the caller and therefore shouldn't be
the return value of this function.
Please drop the return here.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-24 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 14:29 [Qemu-devel] [PATCH v5 0/3] linux-aio: fix batch submission Ming Lei
2014-11-24 14:29 ` [Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch Ming Lei
2014-11-24 16:40 ` Stefan Hajnoczi [this message]
2014-11-24 19:01 ` Stefan Hajnoczi
2014-11-24 14:29 ` [Qemu-devel] [PATCH v5 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case Ming Lei
2014-11-24 18:58 ` Stefan Hajnoczi
2014-11-24 14:29 ` [Qemu-devel] [PATCH v5 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb' Ming Lei
2014-11-24 14:31 ` [Qemu-devel] [PATCH v5 0/3] linux-aio: fix batch submission Paolo Bonzini
2014-11-24 14:50 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124164023.GA14760@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).