From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Xsysy-0001MQ-0t
	for qemu-devel@nongnu.org; Mon, 24 Nov 2014 14:01:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Xsyso-00069h-SH
	for qemu-devel@nongnu.org; Mon, 24 Nov 2014 14:01:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Xsyso-00069V-Jl
	for qemu-devel@nongnu.org; Mon, 24 Nov 2014 14:01:10 -0500
Date: Mon, 24 Nov 2014 19:01:06 +0000
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20141124190106.GA21126@stefanha-thinkpad.redhat.com>
References: <1416839379-19677-1-git-send-email-ming.lei@canonical.com>
	<1416839379-19677-2-git-send-email-ming.lei@canonical.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j"
Content-Disposition: inline
In-Reply-To: <1416839379-19677-2-git-send-email-ming.lei@canonical.com>
Subject: Re: [Qemu-devel] [PATCH v5 1/3] linux-aio: fix submit aio as a batch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ming Lei <ming.lei@canonical.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org


--nFreZHaLTZJo0R7j
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 24, 2014 at 10:29:37PM +0800, Ming Lei wrote:
> +static void ioq_abort_bh(void *opaque)
> +{
> +    struct qemu_laio_state *s =3D opaque;
> +    int i;
> +
> +    for (i =3D 0; i < s->io_q.idx; i++) {
> +        struct qemu_laiocb *laiocb =3D container_of(s->io_q.iocbs[i],
> +                                                  struct qemu_laiocb,
> +                                                  iocb);
> +        laiocb->ret =3D -EIO;
>          qemu_laio_process_completion(s, laiocb);
>      }
> -    return ret;
> +
> +    s->io_q.idx =3D 0;
> +    io_q->aborting =3D false;
>  }

This patch does not compile:

  CC    block/linux-aio.o
  block/linux-aio.c: In function =E2=80=98ioq_abort_bh=E2=80=99:
  block/linux-aio.c:255:5: error: =E2=80=98io_q=E2=80=99 undeclared (first =
use in this function)
       io_q->aborting =3D false;
       ^

--nFreZHaLTZJo0R7j
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUc4ByAAoJEJykq7OBq3PIatMIAMN4rjUHe/6nPsOlMS/vRuBI
2ZU3VihZw1LnH1qX/+0NzibSdzGv4W+zw03MVotrguwusQeZwmGfCSAb9VAZbDuS
5AqsXNNxgBEBMyxa2Uj5WkV4RVuGCK0/j8wkS3+3BUAi55hZPd089O2QgfzQcPoa
FILdHVPZS2QokEhpOfYg685czW1ell0/jFCDlJfZ0vMWRI9dU10J6Kq/t/IMYWgp
nhkX2rQkmwLr2S1wXyW6Tkl59rpN3G3kxabXD6gdbsjCdFX1jmnI/OSWDyVWQ+K0
7jTR6vIKGG6iLfQ4WyKsFIsfQmJg6TVodEypoL9luF4Pty1/9NWy4ahVtms2BGE=
=fWjR
-----END PGP SIGNATURE-----

--nFreZHaLTZJo0R7j--