Re: [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace

[Amos Kong <akong@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2424 bytes --]

On Tue, Nov 25, 2014 at 08:18:54AM +0100, Gerd Hoffmann wrote:
> Ongoing discussions on how we are going to specify the console,
> so tag the command as experiemntal so we can refine things in
> the 2.3 development cycle.

%s/experiemntal/experimental/


Reviewed-by: Amos Kong <akong@redhat.com>

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qmp-commands.hx | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 8812401..d6b7362 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -3791,13 +3791,13 @@ Example:
>  EQMP
>  
>      {
> -        .name       = "input-send-event",
> +        .name       = "x-input-send-event",
>          .args_type  = "console:i?,events:q",
>          .mhandler.cmd_new = qmp_marshal_input_input_send_event,
>      },
>  
>  SQMP
> -@input-send-event
> +@x-input-send-event
>  -----------------
>  
>  Send input event to guest.
> @@ -3815,13 +3815,13 @@ Example (1):
>  
>  Press left mouse button.
>  
> --> { "execute": "input-send-event",
> +-> { "execute": "x-input-send-event",
>      "arguments": { "console": 0,
>                     "events": [ { "type": "btn",
>                      "data" : { "down": true, "button": "Left" } } } }

(not problem of this patch)
typo, lack of ']'

>  <- { "return": {} }
>  
> --> { "execute": "input-send-event",
> +-> { "execute": "x-input-send-event",
>      "arguments": { "console": 0,
>                     "events": [ { "type": "btn",
>                      "data" : { "down": false, "button": "Left" } } } }

some typo.

> @@ -3831,7 +3831,7 @@ Example (2):
>  
>  Press ctrl-alt-del.
>  
> --> { "execute": "input-send-event",
> +-> { "execute": "x-input-send-event",
>       "arguments": { "console": 0, "events": [
>          { "type": "key", "data" : { "down": true,
>            "key": {"type": "qcode", "data": "ctrl" } } },
> @@ -3845,7 +3845,7 @@ Example (3):
>  
>  Move mouse pointer to absolute coordinates (20000, 400).
>  
> --> { "execute": "input-send-event" ,
> +-> { "execute": "x-input-send-event" ,
>    "arguments": { "console": 0, "events": [
>                 { "type": "abs", "data" : { "axis": "X", "value" : 20000 } },
>                 { "type": "abs", "data" : { "axis": "Y", "value" : 400 } } ] } }
> -- 
> 1.8.3.1
> 

-- 
			Amos.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]