From: Luiz Capitulino <lcapitulino@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [Regression] hmp: QEMU crash on device_del auto-completion
Date: Tue, 25 Nov 2014 09:12:56 -0500 [thread overview]
Message-ID: <20141125091256.03b81a5b@redhat.com> (raw)
In-Reply-To: <1416924259.4666.38.camel@localhost.localdomain>
On Tue, 25 Nov 2014 16:04:19 +0200
Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> Hi,
>
> The commits:
> - 6a1fa9f5 (monitor: add del completion for peripheral device)
> - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper)
>
> cause a QEMU crash when trying to use HMP device_del auto-completion.
> It can be easily reproduced by:
> <qemu-bin> -enable-kvm ~/images/fedora.qcow2 -monitor stdio -device virtio-net-pci,id=vnet
> (qemu) device_del /home/mapfelba/git/upstream/qemu/hw/core/qdev.c:941:qdev_build_hotpluggable_device_list: Object 0x7f6ce04e4fe0 is not an instance of type device
> Aborted (core dumped)
>
> The root cause is qdev_build_hotpluggable_device_list going recursively over
> all peripherals and their children assuming all are devices. It doesn't work
> since PCI devices have at least on child which is a memory region (bus master).
>
> Should we try to fix it for 2.2 or simply revert it?
Do you think you can post a patch in the next few days? If you can then
let's try to fix it, otherwise we better revert those commits.
next prev parent reply other threads:[~2014-11-25 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 14:04 [Qemu-devel] [Regression] hmp: QEMU crash on device_del auto-completion Marcel Apfelbaum
2014-11-25 14:12 ` Luiz Capitulino [this message]
2014-11-25 14:23 ` Marcel Apfelbaum
2014-11-26 1:13 ` Zhu Guihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125091256.03b81a5b@redhat.com \
--to=lcapitulino@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel.a@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).