From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtGuA-0003eV-W3 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:15:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtGu4-0001Hw-No for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:15:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtGu4-0001GG-7H for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:15:40 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPEFdtJ007716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 25 Nov 2014 09:15:39 -0500 Date: Tue, 25 Nov 2014 09:15:34 -0500 From: Luiz Capitulino Message-ID: <20141125091534.312b3198@redhat.com> In-Reply-To: <1416923657-10614-1-git-send-email-armbru@redhat.com> References: <1416923657-10614-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for-2.2] input: move input-send-event into experimental namespace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: akong@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Tue, 25 Nov 2014 14:54:17 +0100 Markus Armbruster wrote: > From: Gerd Hoffmann > > Ongoing discussions on how we are going to specify the console, > so tag the command as experiental so we can refine things in > the 2.3 development cycle. > > Signed-off-by: Gerd Hoffmann > [Spell out "not a stable API", and x- the QAPI schema, too] > Signed-off-by: Markus Armbruster > > Signed-off-by: Markus Armbruster > --- > I would've ripped out the command entirely, but Gerd's approach works > for me, too. Since time for -rc3 is running out, I'm respinning his > patch with my and Amos's review comments worked in. Hope that's okay. > > We should also pick Amos's "[PATCH] qmp: fix typo in input-send-event > examples". Is this going to be merged via Gerd's tree or QMP tree? In any case it would be good to have Eric's review. > > qapi-schema.json | 6 ++++-- > qmp-commands.hx | 16 +++++++++------- > ui/input.c | 4 ++-- > 3 files changed, 15 insertions(+), 11 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index d0926d9..9ffdcf8 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3245,7 +3245,7 @@ > 'abs' : 'InputMoveEvent' } } > > ## > -# @input-send-event > +# @x-input-send-event > # > # Send input event(s) to guest. > # > @@ -3257,8 +3257,10 @@ > # > # Since: 2.2 > # > +# Note: this command is experimental, and not a stable API. > +# > ## > -{ 'command': 'input-send-event', > +{ 'command': 'x-input-send-event', > 'data': { '*console':'int', 'events': [ 'InputEvent' ] } } > > ## > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 8812401..718dd92 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -3791,13 +3791,13 @@ Example: > EQMP > > { > - .name = "input-send-event", > + .name = "x-input-send-event", > .args_type = "console:i?,events:q", > - .mhandler.cmd_new = qmp_marshal_input_input_send_event, > + .mhandler.cmd_new = qmp_marshal_input_x_input_send_event, > }, > > SQMP > -@input-send-event > +@x-input-send-event > ----------------- > > Send input event to guest. > @@ -3811,17 +3811,19 @@ The consoles are visible in the qom tree, under > /backend/console[$index]. They have a device link and head property, so > it is possible to map which console belongs to which device and display. > > +Note: this command is experimental, and not a stable API. > + > Example (1): > > Press left mouse button. > > --> { "execute": "input-send-event", > +-> { "execute": "x-input-send-event", > "arguments": { "console": 0, > "events": [ { "type": "btn", > "data" : { "down": true, "button": "Left" } } } } > <- { "return": {} } > > --> { "execute": "input-send-event", > +-> { "execute": "x-input-send-event", > "arguments": { "console": 0, > "events": [ { "type": "btn", > "data" : { "down": false, "button": "Left" } } } } > @@ -3831,7 +3833,7 @@ Example (2): > > Press ctrl-alt-del. > > --> { "execute": "input-send-event", > +-> { "execute": "x-input-send-event", > "arguments": { "console": 0, "events": [ > { "type": "key", "data" : { "down": true, > "key": {"type": "qcode", "data": "ctrl" } } }, > @@ -3845,7 +3847,7 @@ Example (3): > > Move mouse pointer to absolute coordinates (20000, 400). > > --> { "execute": "input-send-event" , > +-> { "execute": "x-input-send-event" , > "arguments": { "console": 0, "events": [ > { "type": "abs", "data" : { "axis": "X", "value" : 20000 } }, > { "type": "abs", "data" : { "axis": "Y", "value" : 400 } } ] } } > diff --git a/ui/input.c b/ui/input.c > index 37ff46f..7ba99e5 100644 > --- a/ui/input.c > +++ b/ui/input.c > @@ -122,8 +122,8 @@ qemu_input_find_handler(uint32_t mask, QemuConsole *con) > return NULL; > } > > -void qmp_input_send_event(bool has_console, int64_t console, > - InputEventList *events, Error **errp) > +void qmp_x_input_send_event(bool has_console, int64_t console, > + InputEventList *events, Error **errp) > { > InputEventList *e; > QemuConsole *con;