From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtCS8-0007di-Ee for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:30:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtCS2-0006Yw-VB for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:30:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtCS2-0006Yl-Kq for qemu-devel@nongnu.org; Tue, 25 Nov 2014 04:30:26 -0500 Date: Tue, 25 Nov 2014 10:30:21 +0100 From: Kevin Wolf Message-ID: <20141125093021.GB4641@noname.redhat.com> References: <1414478736-30064-1-git-send-email-famz@redhat.com> <1414478736-30064-2-git-send-email-famz@redhat.com> <547447ED.9030708@redhat.com> <20141125092125.GA4641@noname.redhat.com> <54744A2B.8060708@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54744A2B.8060708@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Speed up make check-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Peter Maydell , Fam Zheng , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= Am 25.11.2014 um 10:21 hat Max Reitz geschrieben: > On 2014-11-25 at 10:21, Kevin Wolf wrote: > >Am 25.11.2014 um 10:12 hat Max Reitz geschrieben: > >>On 2014-10-28 at 07:45, Fam Zheng wrote: > >>>Using /tmp (usually mounted as tmpfs) and cache=writeback, the quick > >>>group can be quicker. > >>> > >>>On my laptop (Lenovo T430s with Fedora 20), this reduces the time from > >>>50s to 30s. > >>> > >>>Signed-off-by: Fam Zheng > >>>--- > >>> tests/qemu-iotests-quick.sh | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>>diff --git a/tests/qemu-iotests-quick.sh b/tests/qemu-iotests-quick.sh > >>>index 12af731..0b54dbf 100755 > >>>--- a/tests/qemu-iotests-quick.sh > >>>+++ b/tests/qemu-iotests-quick.sh > >>>@@ -3,6 +3,6 @@ > >>> cd tests/qemu-iotests > >>> ret=0 > >>>-./check -T -qcow2 -g quick || ret=1 > >>>+TEST_DIR=/tmp/qemu-iotests-quick-$$ ./check -T -qcow2 -g quick -c writeback || ret=1 > >>There are (at least) two tests which don't work with -c writeback > >>(026 and 039), one of them is in the quick group (039). Why not use > >>-c writethrough? It doesn't make any difference on tmpfs anyway (we > >>can't omit it because that will break 091). > >Why use any -c? The default is the fast option writeback, and for those > >test cases that don't support writeback, something working is chosen > >instead. > > Because that breaks 091. That's unfortunate. I wish tmpfs supported O_DIRECT... But let's just remove it from quick then - it doesn't really matter if it doesn't run because of the cache mode or because we didn't include it in the group. -c writethrough is okay as long as you really have tmpfs on your /tmp, but it really hurts when you don't (and I for one don't, standard RHEL 7 installation). Kevin