From: Stefan Hajnoczi <stefanha@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kwolf@redhat.com,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
Public KVM Mailing List <qemu-devel@nongnu.org>,
armbru@redhat.com, dahi@linux.vnet.ibm.com,
cornelia.huck@de.ibm.com, pbonzini@redhat.com,
mihajlov@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions
Date: Tue, 25 Nov 2014 11:09:23 +0000 [thread overview]
Message-ID: <20141125110923.GC21126@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <546F111E.50808@de.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
On Fri, Nov 21, 2014 at 11:17:02AM +0100, Christian Borntraeger wrote:
> Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova:
> > Move the IOCTL calls that detect logical blocksize from raw_probe_alignment
> > into separate function (probe_logical_blocksize).
> > Introduce function which detect physical blocksize via IOCTL
> > (probe_physical_blocksize).
> > Both functions will be used in the next patch.
> >
> > Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
>
> From what I can tell this should be a no-op for raw_probe_alignment.
>
> probe_physical_blocksize looks also good. When this patch is applied stand-alone,
> gcc will complain about a defined but unused function, though.
>
> So we might want to move this function into patch 3 or just add an __attribute__((unused))
> here (and remove that in patch 3). Or just leave it as is.
Please move probe_physical_blocksize() to Patch 3 because some QEMU
builds default to -Werror where this patch causes a build failure.
(In order for git-bisect(1) to work patches must not break the build.)
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-25 11:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 10:17 [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices Ekaterina Tumanova
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize Ekaterina Tumanova
2014-11-21 10:01 ` Christian Borntraeger
2014-11-27 14:55 ` Markus Armbruster
2014-11-27 16:05 ` Ekaterina Tumanova
2014-11-28 8:25 ` Markus Armbruster
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions Ekaterina Tumanova
2014-11-21 10:17 ` Christian Borntraeger
2014-11-25 11:09 ` Stefan Hajnoczi [this message]
2014-11-27 17:41 ` Markus Armbruster
2014-11-28 10:58 ` Ekaterina Tumanova
2014-11-28 12:52 ` Markus Armbruster
2014-11-28 13:28 ` Ekaterina Tumanova
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry Ekaterina Tumanova
2014-11-21 13:52 ` Christian Borntraeger
2014-11-28 8:43 ` Markus Armbruster
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing Ekaterina Tumanova
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize Ekaterina Tumanova
2014-11-28 10:10 ` Markus Armbruster
2014-11-28 10:54 ` Ekaterina Tumanova
2014-11-28 12:58 ` Markus Armbruster
2014-11-28 10:27 ` Markus Armbruster
2014-11-19 10:17 ` [Qemu-devel] [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing Ekaterina Tumanova
2014-11-28 10:47 ` Markus Armbruster
2014-11-19 11:39 ` [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices Christian Borntraeger
2014-11-19 14:01 ` [Qemu-devel] [PATCH] geometry: fix i386 compilation Ekaterina Tumanova
2014-11-19 14:40 ` Peter Maydell
2014-11-19 15:04 ` Cornelia Huck
2014-11-20 16:18 ` Kevin Wolf
2014-11-20 16:30 ` Christian Borntraeger
2014-11-21 9:42 ` Ekaterina Tumanova
2014-11-28 10:47 ` Markus Armbruster
2014-11-21 14:01 ` [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices Christian Borntraeger
2014-11-25 13:01 ` Stefan Hajnoczi
2014-11-26 10:16 ` Ekaterina Tumanova
2014-11-28 10:35 ` Stefan Hajnoczi
2014-11-28 11:15 ` Ekaterina Tumanova
2014-11-28 13:40 ` Markus Armbruster
2014-11-28 10:40 ` Stefan Hajnoczi
2014-11-28 10:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125110923.GC21126@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).