From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtE05-0005zZ-Ib for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:09:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtDzz-0002A5-Ej for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:09:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtDzz-0002A1-66 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:09:35 -0500 Date: Tue, 25 Nov 2014 11:09:23 +0000 From: Stefan Hajnoczi Message-ID: <20141125110923.GC21126@stefanha-thinkpad.redhat.com> References: <1416392276-10408-1-git-send-email-tumanova@linux.vnet.ibm.com> <1416392276-10408-3-git-send-email-tumanova@linux.vnet.ibm.com> <546F111E.50808@de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0lnxQi9hkpPO77W3" Content-Disposition: inline In-Reply-To: <546F111E.50808@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: kwolf@redhat.com, Ekaterina Tumanova , Public KVM Mailing List , armbru@redhat.com, dahi@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, mihajlov@linux.vnet.ibm.com --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 21, 2014 at 11:17:02AM +0100, Christian Borntraeger wrote: > Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova: > > Move the IOCTL calls that detect logical blocksize from raw_probe_align= ment > > into separate function (probe_logical_blocksize). > > Introduce function which detect physical blocksize via IOCTL > > (probe_physical_blocksize). > > Both functions will be used in the next patch. > >=20 > > Signed-off-by: Ekaterina Tumanova >=20 > From what I can tell this should be a no-op for raw_probe_alignment. >=20 > probe_physical_blocksize looks also good. When this patch is applied stan= d-alone, > gcc will complain about a defined but unused function, though. >=20 > So we might want to move this function into patch 3 or just add an __attr= ibute__((unused)) > here (and remove that in patch 3). Or just leave it as is. Please move probe_physical_blocksize() to Patch 3 because some QEMU builds default to -Werror where this patch causes a build failure. (In order for git-bisect(1) to work patches must not break the build.) Stefan --0lnxQi9hkpPO77W3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUdGNjAAoJEJykq7OBq3PITvMIALKUvMP2T5DM65QiEHjI5E4N pLXrfHN46wCxhSjFunhwCcNcSPCUMb44kYoKaJTxj2TJD1O75ZnpkIp9X9JRqGjY 5eV+BdTTwTmvqM+cbEFdkn04Fb9QCQ5rXCd6I0lkxYEKMZE56+5Sgbxs2JWDVhAV PkFyrPeSYm6O6xl2a9VkXBUz49Z1vri/a4bIyoanLytrmWPjIOd2G5gdEWG38+so vxhiWtQuBQsxasmEqlkmZbnuzbutFluXKanJhjXLwRpqDEA7CmsEaE0pcfDnoJvt P2FCa2alViSTAn3PNCbsAkHjZKJX/PKDHTrYrRIUK3uYSnIlfwI8b9XcwraosJQ= =2H1V -----END PGP SIGNATURE----- --0lnxQi9hkpPO77W3--