From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtFkJ-00070s-DY for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:01:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtFkD-0006Fn-TO for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:01:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtFkD-0006FM-LY for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:01:25 -0500 Date: Tue, 25 Nov 2014 13:01:15 +0000 From: Stefan Hajnoczi Message-ID: <20141125130115.GD21126@stefanha-thinkpad.redhat.com> References: <1416392276-10408-1-git-send-email-tumanova@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UoPmpPX/dBe4BELn" Content-Disposition: inline In-Reply-To: <1416392276-10408-1-git-send-email-tumanova@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ekaterina Tumanova Cc: kwolf@redhat.com, dahi@linux.vnet.ibm.com, Public KVM Mailing List , armbru@redhat.com, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, mihajlov@linux.vnet.ibm.com --UoPmpPX/dBe4BELn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote: > Hi folks, >=20 > I'm sorry for the recent spam. I messed up during code submission last ti= me. > So please ignore any previous notes you received from me and answer only = to > this thread. >=20 > This is the rework of the geometry+blocksize patch, which was > recently discussed here: > http://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01148.html >=20 > Markus suggested that we only detect blocksize and geometry for DASDs. >=20 > According to this agreement new version contains DASD special casing. > The driver methods are implemented only for "host_device" and inner hdev_= xxx > functions check if the backing storage is a DASD by means of > BIODASDINFO2 ioctl. >=20 > Original patchset can be found here: > http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg03791.html This is description is mainly a changelog. Links to previous email threads are useful for additional info but please include a self-contained description of the series and the rationale behind it. Comments: 1. This series overrides the logical_block_size and physical_block_size options for raw images on DASD devices. Users expect their command-line options to be honored, so the options should not be overriden if they have been given on the command-line. 2. Only virtio_blk is modified, this is inconsistent. All emulated storage controllers using BlockConf have the same block size probing behavior. 3. Why does s390 need to customize hd_geometry_guess()? 4. Please use scripts/checkpatch.pl to check coding style. --UoPmpPX/dBe4BELn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUdH2bAAoJEJykq7OBq3PI5GIH/0O7D5y++rH62Gai05V9xX+u +kbWSxHYNnohAxgfMk4hmmvVD1gWHru5rlQW3qU6OJzBY5SfaDiMQS5AUPVtNkvb 85etOJXv+BQTs3MXXhBpMa4UDxKpYJt7sH2BEMw58YAm+dzFsFJek4nqV5tOc1wo 89pANYzAGkaMyL2nhhOqt3XMV9Fk2hEog5ikzLvbEzpOhU1XXfADzex/uhSK+WgL 4rUk72xktWzj7sMNM0SDLIamuphdWZitxqRszrpqUBOQVYT1zj0WVUzZUzzriKWf x8+qT53udYfAgJo0qvnubIqja+jmY1/h9kHs9o8cCjSiQAkg8pZcNiyfOZ7vxbs= =0Aq4 -----END PGP SIGNATURE----- --UoPmpPX/dBe4BELn--