From: Stefan Hajnoczi <stefanha@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case
Date: Tue, 25 Nov 2014 13:14:37 +0000 [thread overview]
Message-ID: <20141125131437.GF21126@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1416900193-3763-3-git-send-email-ming.lei@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Tue, Nov 25, 2014 at 03:23:12PM +0800, Ming Lei wrote:
> Previously -EAGAIN is simply ignored for !s->io_q.plugged case,
> and sometimes it is easy to cause -EIO to VM, such as NVME device.
>
> This patch handles -EAGAIN by io queue for !s->io_q.plugged case,
> and it will be retried in following aio completion cb.
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
> block/linux-aio.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-25 13:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 7:23 [Qemu-devel] [PATCH v6 0/3] linux-aio: fix batch submission Ming Lei
2014-11-25 7:23 ` [Qemu-devel] [PATCH v6 1/3] linux-aio: fix submit aio as a batch Ming Lei
2014-11-25 13:08 ` Stefan Hajnoczi
2014-11-25 14:45 ` Ming Lei
2014-11-25 16:18 ` Stefan Hajnoczi
2014-11-26 9:15 ` Ming Lei
2014-11-27 16:56 ` Stefan Hajnoczi
2014-11-27 16:58 ` Paolo Bonzini
2014-11-28 3:01 ` Ming Lei
2014-11-26 11:18 ` Kevin Wolf
2014-11-28 2:16 ` Ming Lei
2014-11-26 14:48 ` Kevin Wolf
2014-11-25 7:23 ` [Qemu-devel] [PATCH v6 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case Ming Lei
2014-11-25 13:14 ` Stefan Hajnoczi [this message]
2014-11-26 11:27 ` Kevin Wolf
2014-11-28 2:27 ` Ming Lei
2014-11-28 11:26 ` Kevin Wolf
2014-11-25 7:23 ` [Qemu-devel] [PATCH v6 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb' Ming Lei
2014-11-25 13:14 ` Stefan Hajnoczi
2014-11-26 11:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125131437.GF21126@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).