From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtFx9-0004PH-Ou for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:14:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtFx4-0006gl-RK for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:14:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtFx4-0006gS-Ix for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:14:42 -0500 Date: Tue, 25 Nov 2014 13:14:37 +0000 From: Stefan Hajnoczi Message-ID: <20141125131437.GF21126@stefanha-thinkpad.redhat.com> References: <1416900193-3763-1-git-send-email-ming.lei@canonical.com> <1416900193-3763-3-git-send-email-ming.lei@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GLp9dJVi+aaipsRk" Content-Disposition: inline In-Reply-To: <1416900193-3763-3-git-send-email-ming.lei@canonical.com> Subject: Re: [Qemu-devel] [PATCH v6 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org --GLp9dJVi+aaipsRk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 25, 2014 at 03:23:12PM +0800, Ming Lei wrote: > Previously -EAGAIN is simply ignored for !s->io_q.plugged case, > and sometimes it is easy to cause -EIO to VM, such as NVME device. >=20 > This patch handles -EAGAIN by io queue for !s->io_q.plugged case, > and it will be retried in following aio completion cb. >=20 > Reviewed-by: Paolo Bonzini > Suggested-by: Paolo Bonzini > Signed-off-by: Ming Lei > --- > block/linux-aio.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi --GLp9dJVi+aaipsRk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUdIC9AAoJEJykq7OBq3PIiDQH/RMjOoKrP5eUyNI3zMHz5eik 2ATxTNhD0dhOxrXn2iHy8APyKYebPt6nH692ix4GUJdXr7oI6x6B3UDehx7GdfZg P08YbezhZtNDhrszru/RCtfxTZ75+n/6HMB3UaZebl9guP9PhX2AO735kOcKSi7i /XuH8xDpwVPlym3CHZKu9qBNko2MeZc8V4BTdEABUQv/O7bLU6ogAPIgaVq1NUvn fDH7jLrWqecBoRAPuHfaVvqgpyJUvl26B+EmgKgAivWGhOlq+hEt09QS+cqWC4o3 rrJPnSq4Jt+tT6vk1xEVy5NJdECy9bSvlpfW1BlIbM3f9onh4nQTbRY26Ivfzog= =eCrA -----END PGP SIGNATURE----- --GLp9dJVi+aaipsRk--