From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtGJy-0002QR-OS for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:38:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtGJn-00048L-G1 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:38:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtGJn-00047q-8D for qemu-devel@nongnu.org; Tue, 25 Nov 2014 08:38:11 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPDc9eP016667 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 25 Nov 2014 08:38:10 -0500 Date: Tue, 25 Nov 2014 13:38:07 +0000 From: Stefan Hajnoczi Message-ID: <20141125133807.GI21126@stefanha-thinkpad.redhat.com> References: <1416902879-17422-1-git-send-email-famz@redhat.com> <1416902879-17422-4-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zqjkMoGlbUJ91oFe" Content-Disposition: inline In-Reply-To: <1416902879-17422-4-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.3 3/5] poll: Add epoll implementation for qemu_poll List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org --zqjkMoGlbUJ91oFe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 25, 2014 at 04:07:57PM +0800, Fam Zheng wrote: > +QEMUPoll *qemu_poll_new(void) > +{ > + int epollfd; > + QEMUPoll *qpoll = g_new0(QEMUPoll, 1); > + epollfd = epoll_create1(EPOLL_CLOEXEC); > + if (epollfd < 0) { > + perror("epoll_create1:"); > + abort(); > + } > + qpoll->epollfd = epollfd; > + qpoll->max_events = 1; > + g_free(qpoll->events); What is the point of this g_free() call? --zqjkMoGlbUJ91oFe Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUdIY/AAoJEJykq7OBq3PIm1cH/ikrriV+amyH7W3OoiJWR/wK 3n21TFT6lI8kaCN87Hp3Vt2ubVgPTd7NZVq08nmI2Y+BdW6Mv09MsbQIXum/4YSw 7axQqpjuGIkoC9K16AL5nfzzV2SRPGJ+RYAbamcM5s4BtLWH7kCO9puO/cJtUXLH qwP+JAnF62U/J2PhZz32kZApRKo0alu3wjrzU/SuAnMygjNadWHTqZ98NDE+f6Hh Wih8v+yX3f4d5nRLFTWOEzsXHLYPiCftn8XSl6nwY7DjsArdq75ONddfmJjGNO0F VI5YUPHkjF+VE0kEbTiRmKiogd7EreLFTyfFx4UCnFVFpoBapAhultGPCbJ6R6g= =7U9B -----END PGP SIGNATURE----- --zqjkMoGlbUJ91oFe--