From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtI2q-0007to-Se for qemu-devel@nongnu.org; Tue, 25 Nov 2014 10:28:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtI2k-0007EU-N0 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 10:28:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtI2k-0007E9-FX for qemu-devel@nongnu.org; Tue, 25 Nov 2014 10:28:42 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPFSffk020331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 25 Nov 2014 10:28:41 -0500 Date: Tue, 25 Nov 2014 23:28:48 +0800 From: Amos Kong Message-ID: <20141125152848.GB26731@air.redhat.com> References: <1416923657-10614-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Yylu36WmvOXNoKYn" Content-Disposition: inline In-Reply-To: <1416923657-10614-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 for-2.2] input: move input-send-event into experimental namespace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com --Yylu36WmvOXNoKYn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 25, 2014 at 02:54:17PM +0100, Markus Armbruster wrote: > From: Gerd Hoffmann >=20 > Ongoing discussions on how we are going to specify the console, > so tag the command as experiental so we can refine things in > the 2.3 development cycle. >=20 > Signed-off-by: Gerd Hoffmann > [Spell out "not a stable API", and x- the QAPI schema, too] > Signed-off-by: Markus Armbruster >=20 > Signed-off-by: Markus Armbruster > --- > I would've ripped out the command entirely, but Gerd's approach works > for me, too. Since time for -rc3 is running out, I'm respinning his > patch with my and Amos's review comments worked in. Hope that's okay. >=20 > We should also pick Amos's "[PATCH] qmp: fix typo in input-send-event > examples". Reviewed-by: Amos Kong =20 > qapi-schema.json | 6 ++++-- > qmp-commands.hx | 16 +++++++++------- > ui/input.c | 4 ++-- > 3 files changed, 15 insertions(+), 11 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index d0926d9..9ffdcf8 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3245,7 +3245,7 @@ > 'abs' : 'InputMoveEvent' } } > =20 > ## > -# @input-send-event > +# @x-input-send-event > # > # Send input event(s) to guest. > # > @@ -3257,8 +3257,10 @@ > # > # Since: 2.2 > # > +# Note: this command is experimental, and not a stable API. > +# > ## > -{ 'command': 'input-send-event', > +{ 'command': 'x-input-send-event', > 'data': { '*console':'int', 'events': [ 'InputEvent' ] } } > =20 > ## > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 8812401..718dd92 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -3791,13 +3791,13 @@ Example: > EQMP > =20 > { > - .name =3D "input-send-event", > + .name =3D "x-input-send-event", > .args_type =3D "console:i?,events:q", > - .mhandler.cmd_new =3D qmp_marshal_input_input_send_event, > + .mhandler.cmd_new =3D qmp_marshal_input_x_input_send_event, > }, > =20 > SQMP > -@input-send-event > +@x-input-send-event > ----------------- > =20 > Send input event to guest. > @@ -3811,17 +3811,19 @@ The consoles are visible in the qom tree, under > /backend/console[$index]. They have a device link and head property, so > it is possible to map which console belongs to which device and display. > =20 > +Note: this command is experimental, and not a stable API. > + > Example (1): > =20 > Press left mouse button. > =20 > --> { "execute": "input-send-event", > +-> { "execute": "x-input-send-event", > "arguments": { "console": 0, > "events": [ { "type": "btn", > "data" : { "down": true, "button": "Left" } } } } > <- { "return": {} } > =20 > --> { "execute": "input-send-event", > +-> { "execute": "x-input-send-event", > "arguments": { "console": 0, > "events": [ { "type": "btn", > "data" : { "down": false, "button": "Left" } } } } > @@ -3831,7 +3833,7 @@ Example (2): > =20 > Press ctrl-alt-del. > =20 > --> { "execute": "input-send-event", > +-> { "execute": "x-input-send-event", > "arguments": { "console": 0, "events": [ > { "type": "key", "data" : { "down": true, > "key": {"type": "qcode", "data": "ctrl" } } }, > @@ -3845,7 +3847,7 @@ Example (3): > =20 > Move mouse pointer to absolute coordinates (20000, 400). > =20 > --> { "execute": "input-send-event" , > +-> { "execute": "x-input-send-event" , > "arguments": { "console": 0, "events": [ > { "type": "abs", "data" : { "axis": "X", "value" : 20000 = } }, > { "type": "abs", "data" : { "axis": "Y", "value" : 400 } = } ] } } > diff --git a/ui/input.c b/ui/input.c > index 37ff46f..7ba99e5 100644 > --- a/ui/input.c > +++ b/ui/input.c > @@ -122,8 +122,8 @@ qemu_input_find_handler(uint32_t mask, QemuConsole *c= on) > return NULL; > } > =20 > -void qmp_input_send_event(bool has_console, int64_t console, > - InputEventList *events, Error **errp) > +void qmp_x_input_send_event(bool has_console, int64_t console, > + InputEventList *events, Error **errp) > { > InputEventList *e; > QemuConsole *con; > --=20 > 1.9.3 --=20 Amos. --Yylu36WmvOXNoKYn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUdKAwAAoJELxSv6I5vP9jpLQP/jU542BTIZ6K7ru6Koyu4H0O nACQs0rNIeZGYpw4mz+pDeXmRgwTpOUAt1uwZugiU/s/+1em9MMPwce2auQZ6mXz cHVDMId5zBi7+ClMkqA54dBJHykFxhl4sxJKzN0ukgp4+e+Ef9P9p45m1wjkKEBc VMIRwv5blY8Fva4NtshH1KCNJvnMGY48lJ9LUYWGa1OjkpaHvpiBJNg1mwgqQt/P dO/ZFwuxcG6PWKDDNSkE/U2NijEeYhp7kJt39HDha3LsHq9i2QXOqykdakygi1e7 ezjXYyc7g0rcfSn5aPMY3FaTBT5VCiifqjI5WcYRJherfgJuHsWA5o0zYxI1OKNI stZP/O4l15TngKjg5fqoifzKlKR/yEG/1zEl0RIF3R0TjXeXObqLW6tMQO9saukz N5D0DZGek9bmuRscID7ZCNIRGZdTsz9KhrQA35Cus2IpFs0jt4edp7/Qf/6l5EhZ +kShJ+LPTVoRXWYKFCkPA2At0old7wja8Ms4XLEG+wVN1+Vt+yuzGWosCVvnOCH9 lwMC2s4p2o/ydsVRJTRDOn9ztqXKTe4VQqCi3HTLrE1lIl/g7dsf9CCaOlV8KW0d o7ODLzl/Nq+tLEE0H1d+NxA/TKVrvBNoiW62e7MRMz5zJXma3If323+lIIZhny5R i70GQBAA56SrPYEWrEZr =tmQN -----END PGP SIGNATURE----- --Yylu36WmvOXNoKYn--