From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtII6-0004gd-6S for qemu-devel@nongnu.org; Tue, 25 Nov 2014 10:44:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtII1-0005po-3A for qemu-devel@nongnu.org; Tue, 25 Nov 2014 10:44:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtII0-0005pe-RR for qemu-devel@nongnu.org; Tue, 25 Nov 2014 10:44:29 -0500 Date: Tue, 25 Nov 2014 15:44:00 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141125154359.GH2550@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-17-git-send-email-dgilbert@redhat.com> <543F814F.6030105@huawei.com> <20141103034746.GM8949@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141103034746.GM8949@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com, zhanghailiang * David Gibson (david@gibson.dropbear.id.au) wrote: > On Thu, Oct 16, 2014 at 04:26:55PM +0800, zhanghailiang wrote: > > On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote: > > >From: "Dr. David Alan Gilbert" > [snip] > > > >+ case MIG_RPCOMM_ACK: > > >+ tmp32 = be32_to_cpup((uint32_t *)buf); > > >+ DPRINTF("RP: Received ACK 0x%x", tmp32); > > >+ atomic_xchg(&ms->rp_state.latest_ack, tmp32); > > > > I didn't see *ms->rp_state.latest_ack* been used elsewhere, what's it used for?;) > > Also, you don't appear to use tmp32 after that point, so what's the > reason for the exchange, rather than just an assignment? I've killed the 'latest_ack' off; I've kept the DPRINTF (and might turn it into a trace). Dave > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK