From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45921)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XtJQD-0004CT-CE
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 11:57:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XtJQ7-0006Qw-Ql
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 11:57:01 -0500
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:34256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XtJQ7-0006Qk-HD
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 11:56:55 -0500
Received: by mail-wi0-f176.google.com with SMTP id ex7so9810343wid.3
	for <qemu-devel@nongnu.org>; Tue, 25 Nov 2014 08:56:54 -0800 (PST)
Date: Tue, 25 Nov 2014 16:56:52 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20141125165652.GD22421@stefanha-thinkpad.redhat.com>
References: <1416474426-12176-1-git-send-email-arei.gonglei@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="jCrbxBqMcLqd4mOl"
Content-Disposition: inline
In-Reply-To: <1416474426-12176-1-git-send-email-arei.gonglei@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>


--jCrbxBqMcLqd4mOl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 20, 2014 at 05:07:06PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>=20
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
>  &fg is passed to bg
>  &bg is passed to fg
>=20
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  ui/vnc-enc-tight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--jCrbxBqMcLqd4mOl
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUdLTUAAoJEJykq7OBq3PISYgH/jYFWF3vORWy/D3Vg/qH9axz
SFR1afWaOx9+8PUdyHrkutaGKLcMp10vKa7jbPb3uX7G2ld46BXus+S+6iZ0E6lz
4VKKgLUOLkMybEMsT/BPODVpRQV5brfcW/pFpAUgvjoUbm4kV6RA8NV6fFd/yczj
MO5LXlZHLZJqplswRq4pG9YWL57ANvwB7Gmg/n7b/wQLM48LrvpWhR3kXGw5Y8xF
MUwFGLNC0gKU04+KhRnpzkMR9ue4Jy3eSjr++SIpFpgbOPK4SadkO/OUubl1uJFC
uQpfqyUTI/KIjgnOKQAslT6qFqlqcf+yPI4Vo9bJy1hPxjmbrqvHrKhSfdYLM00=
=xvU5
-----END PGP SIGNATURE-----

--jCrbxBqMcLqd4mOl--