From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtJju-0005UK-J1 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:17:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtJji-00057P-NE for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:17:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtJji-00056l-EO for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:17:10 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPHH8C9023028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 25 Nov 2014 12:17:09 -0500 Date: Tue, 25 Nov 2014 17:17:07 +0000 From: Stefan Hajnoczi Message-ID: <20141125171707.GB24357@stefanha-thinkpad.redhat.com> References: <1416925164-17848-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8GpibOaaTibBMecb" Content-Disposition: inline In-Reply-To: <1416925164-17848-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Don't probe for unknown backing file format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com --8GpibOaaTibBMecb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 25, 2014 at 03:19:24PM +0100, Kevin Wolf wrote: > If a qcow2 image specifies a backing file format that doesn't correspond > to any format driver that qemu knows, we shouldn't fall back to probing, > but simply error out. >=20 > Not looking up the backing file driver in bdrv_open_backing_file(), but > just filling in the "driver" option if it isn't there moves us closer to > the goal of having everything in QDict options and gets us the error > handling of bdrv_open(), which correctly refuses unknown drivers. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 7 +++--- > tests/qemu-iotests/114 | 62 ++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/qemu-iotests/114.out | 13 ++++++++++ > tests/qemu-iotests/group | 1 + > 4 files changed, 79 insertions(+), 4 deletions(-) > create mode 100755 tests/qemu-iotests/114 > create mode 100644 tests/qemu-iotests/114.out Looks good, modulo the test failure that Max noticed. --8GpibOaaTibBMecb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUdLmTAAoJEJykq7OBq3PI3rIH/1dU0NyfJnt5H/WCRwk08wDS aBghXgL3qtZ21quki1vuI8igEmCG20kIuGHtwEVXKI9y4VhvJXrSM05TiN7Vdv+y EKlQk81keLKO0dhKbWzIoaqtKqf0FMginXIPwBA8Rw44+jLguhs4YZ40bvW84muI eXwG0UIjCMSrZt9M4qa1hqs+bMPnl10baZPfpAR2/ob81BMopjDZcvPP9wHmdfmF h53hnJZUdwSglQMIalK7bPFWEYZ6xcONu1xPJOXYDnKAjRdCzlfMhc95yY0NzBh/ hFNABGUSHaIzB7FXZsU7Szob1qQ7Ov+B0Mq76s2jDiGIUjgF+ogbTo01Y8C6a4A= =ogR2 -----END PGP SIGNATURE----- --8GpibOaaTibBMecb--