From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtJNJ-000204-Kn for qemu-devel@nongnu.org; Tue, 25 Nov 2014 11:54:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtJNB-0005HM-Kp for qemu-devel@nongnu.org; Tue, 25 Nov 2014 11:54:01 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:45245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtJNB-0005HI-CB for qemu-devel@nongnu.org; Tue, 25 Nov 2014 11:53:53 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Nov 2014 16:53:52 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 757CA2190045 for ; Tue, 25 Nov 2014 16:53:23 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAPGroEi18743630 for ; Tue, 25 Nov 2014 16:53:50 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAPGro9v032026 for ; Tue, 25 Nov 2014 09:53:50 -0700 Date: Tue, 25 Nov 2014 17:53:48 +0100 From: Michael Mueller Message-ID: <20141125175348.4b8d2f9f@bee> In-Reply-To: <87zjbf9y15.fsf@blackfin.pond.sub.org> References: <1416910178-5088-1-git-send-email-mreitz@redhat.com> <87k32jii7e.fsf@blackfin.pond.sub.org> <54747629.8060709@redhat.com> <87sih7fmd8.fsf@blackfin.pond.sub.org> <547482A5.1050509@redhat.com> <87mw7fcrwg.fsf@blackfin.pond.sub.org> <54748913.5050200@redhat.com> <87zjbf9y15.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] iotests: Fix test 039 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Fam Zheng , Mao Chuan Li , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi On Tue, 25 Nov 2014 15:04:38 +0100 Markus Armbruster wrote: > Max Reitz writes: > > > On 2014-11-25 at 14:48, Markus Armbruster wrote: > >> Max Reitz writes: > >> > >>> On 2014-11-25 at 14:20, Markus Armbruster wrote: > >>>> Max Reitz writes: > >>>> > >>>>> On 2014-11-25 at 13:21, Markus Armbruster wrote: > >>>>>> Max Reitz writes: > >>>>>> > >>>>>>> Test 039 used to fail > >>>>>> I'm confused: "used to" suggests it doesn't anymore, but you sending a > >>>>>> patches strongly suggests something's broken. > >>>>> Well, it used to fail before this series. :-P > >>>>> > >>>>> You're right, this sounds bad. Currently, 039 does fail, at least on > >>>>> any system with a /proc/sys/kernel/core_pattern passing the dump to > >>>>> another program. After this series, it does no longer. > >>>>> > >>>>>>> because qemu-io -c abort may generate core dumps > >>>>>>> even with ulimit -c 0 (and the output then contains "(core dumped)"). > >>>>>> How? > >>>>> See the patches[1][2] by Mao Chuan Li. If > >>>>> /proc/sys/kernel/core_pattern passes the dump to another program, > >>>>> ulimit -c 0 does not matter. > >>>>> > >>>>> [1] http://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg02092.html > >>>>> [2] http://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg02093.html > >>>>> > >>>>> The problem with those patches is that they require access to > >>>>> /proc/sys/kernel/core_pattern. I don't like having to run the iotests > >>>>> as root. > >>>> To me, this sounds like a case of "doctor, it hurts when I do this". > >>> What do you mean? That I don't want the iotests to run as root? Or > >>> that I don't want to go the alternative of filtering out the "(core > >>> dumped)" message? > >> I mean: > >> > >> Doctor, it hurts when I write weird stuff to > >> /proc/sys/kernel/core_pattern. > >> > >> Don't do that then. > >> > >> If you want to be a nicer doc than me, go right ahead. > > > > I don't write weird stuff there. My default system configuration does > > (and mine is not the only one): > > > > $ uname -r > > 3.17.3-200.fc20.x86_64 > > $ cat /proc/sys/kernel/core_pattern > > |/usr/sbin/chroot /proc/%P/root /usr/libexec/abrt-hook-ccpp %s %c %p > > %u %g %t e > > abrt is one of the things I kill with prejudice on all my development > machines. Markus, we use non-personal test machines that shall automatically start tests like iotests when patches are committed, thus this series really helps... Thanks. Michael >