Re: [Qemu-devel] [PATCH v3 0/2] block: Improve filename generation for blkdebug

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

On Tue, Nov 11, 2014 at 10:23:43AM +0100, Max Reitz wrote:
> Eric has gloriously reviewed v2 of this series, and by adopting v2
> averted a kitten crisis and the need for me to find a freely usable
> kitten picture (although I guess Wikipedia would have been the way to
> go). I do have own pictures, but they are currently about 400 km air
> distance away from me.
> 
> 
> The changes in v3:
> - Patch 1: Added a check for the "config" option being NULL (which
>   happens if no config file is given, either by just not giving the
>   option or by using the blkdebug::foo syntax); in this case, omit the
>   config filename from the output (to receive "blkdebug::foo") [Eric]
> - Patch 2: Add a test for this case
> 
> 
> git-backport-diff output against v2 (and v1):
> 
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
> 
> 001/2:[0003] [FC] 'blkdebug: Simplify and improve filename generation'
> 002/2:[0010] [FC] 'iotests: Plain blkdebug filename generation'
> 
> 
> Max Reitz (2):
>   blkdebug: Simplify and improve filename generation
>   iotests: Plain blkdebug filename generation
> 
>  block/blkdebug.c           | 99 +++++++++++++---------------------------------
>  tests/qemu-iotests/099     | 15 ++++++-
>  tests/qemu-iotests/099.out | 12 +++++-
>  3 files changed, 52 insertions(+), 74 deletions(-)
> 
> -- 
> 1.9.3
> 
> 

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]