qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Xiaodong Gong <gordongong0350@gmail.com>
Cc: kwolf@redhat.com, petrutlucian94@gmail.com,
	brian.luohao@huawei.com, hahn@univention.de,
	hutao@cn.fujitsu.com, jcody@redhat.com, cyliu@suse.com,
	qemu-devel@nongnu.org, ssdxiao@163.com, arei.gonglei@huawei.com,
	stefanha@redhat.com, Xiaodong Gong <gongxiaodong1@huawei.com>,
	rudy.zhangmin@huawei.com
Subject: Re: [Qemu-devel] [PATCH RESEND] Support vhd type VHD_DIFFERENCING
Date: Wed, 26 Nov 2014 15:57:34 +0000	[thread overview]
Message-ID: <20141126155734.GC14288@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1415285030-23278-1-git-send-email-gongxiaodong1@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

On Thu, Nov 06, 2014 at 10:43:50PM +0800, Xiaodong Gong wrote:
> Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu
> can't read snapshot volume of vhd, and can't support other storage
> features of vhd file.
> 
> This patch add read parent information in function "vpc_open", read
> bitmap in "vpc_read", and change bitmap in "vpc_write".
> 
> Signed-off-by: Xiaodong Gong <gongxiaodong1@huawei.com>
> Reviewed-by: Ding xiao <ssdxiao@163.com>
> ---

Have you run tests/qemu-iotests/check for all 3 subformats (fixed,
dynamic, and differencing)?

http://qemu-project.org/Documentation/QemuIoTests

The tests need to pass before we can merge a new subformat.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2014-11-26 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 14:43 [Qemu-devel] [PATCH RESEND] Support vhd type VHD_DIFFERENCING Xiaodong Gong
2014-11-26 15:32 ` Stefan Hajnoczi
2015-02-08 12:19   ` Xiaodong Gong
2014-11-26 15:57 ` Stefan Hajnoczi [this message]
2015-02-08 13:24   ` Xiaodong Gong
  -- strict thread matches above, loose matches on Subject: below --
2014-10-10 16:17 Xiaodong Gong
2014-10-11  1:02 ` Gonglei
2014-10-14 13:32   ` Xiaodong Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141126155734.GC14288@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=arei.gonglei@huawei.com \
    --cc=brian.luohao@huawei.com \
    --cc=cyliu@suse.com \
    --cc=gongxiaodong1@huawei.com \
    --cc=gordongong0350@gmail.com \
    --cc=hahn@univention.de \
    --cc=hutao@cn.fujitsu.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=petrutlucian94@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rudy.zhangmin@huawei.com \
    --cc=ssdxiao@163.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).