From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtfLG-0003Hp-BW for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:21:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtfL9-0001Go-DQ for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:21:22 -0500 Date: Wed, 26 Nov 2014 16:21:12 +0000 From: Stefan Hajnoczi Message-ID: <20141126162112.GF14288@stefanha-thinkpad.redhat.com> References: <1416380832-9697-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GV0iVqYguTV4Q9ER" Content-Disposition: inline In-Reply-To: <1416380832-9697-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] tests: Use "command -v" instead of which(1) in shell scripts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-trivial@nongnu.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com --GV0iVqYguTV4Q9ER Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 19, 2014 at 03:07:12PM +0800, Fam Zheng wrote: > When which(1) is not installed, we would complain "perl not found" > because it's the first set_prog_path check. The error message is > wrong. >=20 > Fix it by using "command -v", a native way to query the existence of a > command. >=20 > Suggested-by: Eric Blake > Signed-off-by: Fam Zheng >=20 > --- > v2: Use "command -v" as suggested by Eric. Also change a few other > occasions of which(1) in tests/qemu-iotests/common. > --- > tests/qemu-iotests/common | 8 ++++---- > tests/qemu-iotests/common.config | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan --GV0iVqYguTV4Q9ER Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUdf34AAoJEJykq7OBq3PICZAH/2WGMoGLbvcbWQAx/12PQgVn cgzR/+JptGVlISOvyKAdO9jc4qWkPctig6pjWA1ZWUpPjHHfGEGOuyVBpNnwkZef FHuZsdXyuQk3oE6FS2JmtotKMIhuGeVV/QcNtdNP2TDNufPBejEMLPH3D/LYdrTN slWjx0XIP4qODI/RR2yW5qwlHxd7ct17UGWpQ0+6660ygBSqQ3+KiVF6j/HvssYi kFK9kpJUEeBZ1/SYFw0XUezFYKW9FulJroQsMEAKtXigg7Ujq+Ivxwdkm1Nr1iHU gOP1QLGKlG9VoL36N33/vR9pB+BonE4RXI11GI4pcqwXeNJBakd1WP3nRI8jOvU= =SHKR -----END PGP SIGNATURE----- --GV0iVqYguTV4Q9ER--