From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37982)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XuAAl-0002jl-6a
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 20:16:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XuAAe-00016l-UJ
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 20:16:35 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40934)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XuAAe-00016W-N3
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 20:16:28 -0500
Date: Fri, 28 Nov 2014 09:16:46 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20141128011646.GA27676@fam-t430.nay.redhat.com>
References: <1417105946-27374-1-git-send-email-mst@redhat.com>
	<CAJSP0QX-7Vt3YwqzJyTmTh_UrSqMRE=xUJOHWcvP_9qD1TB97w@mail.gmail.com>
	<20141127211304.GA26295@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141127211304.GA26295@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC for-2.2] virtio-blk: force 1st s/g to
 match header
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, peter.maydell@linaro.org

On Thu, 11/27 23:13, Michael S. Tsirkin wrote:
> On Thu, Nov 27, 2014 at 07:21:35PM +0000, Stefan Hajnoczi wrote:
> > On Thu, Nov 27, 2014 at 4:33 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > We leak cpu mappings when 1st s/g is not exactly the
> > > header. As we don't set ANY_LAYOUT, we can at this point
> > > simply assert the correct length.
> > >
> > > This will have to be fixed once ANY_LAYOUT is set.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > >
> > > Untested: posting for early feedback.
> > 
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> Stefan, you are going to merge this for 2.2?
> Peter, if Stefan is merging this one, we can
> take Jason's patch for -net and that should be
> enough for 2.2.

My test bot saw a failure of "make check":

qemu-system-x86_64: virtio-blk request outhdr too long
Broken pipe
GTester: last random seed: R02S44c5a09d74c0603f0091ed20d1395121
qemu-system-x86_64: virtio-blk request outhdr too long
Broken pipe
GTester: last random seed: R02Sfdf270c8e1ed75c1f2047e3f0fb89b88
qemu-system-x86_64: virtio-blk request outhdr too long
Broken pipe
GTester: last random seed: R02Sd292c540929b963ed9d7d155f3db5452
qemu-system-x86_64: virtio-blk request outhdr too long
Broken pipe
GTester: last random seed: R02Sfc775a34a844c39f376aa478eda7573f
[vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. Task offloads will be emulated.
make: *** [check-qtest-x86_64] Error 1

Fam