From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, ming.lei@canonical.com, pl@kamp.de,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench
Date: Fri, 28 Nov 2014 11:49:53 +0000 [thread overview]
Message-ID: <20141128114953.GG13631@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1417013204-30676-2-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote:
> + while (data.n > 0) {
> + main_loop_wait(false);
> + }
Why is this false (non-blocking)? This is why you get the main loop
spun warning message.
Using true (blocking) seems like the right thing. data.n changes as
part of the callback, which is invoked from the main loop. There is no
need to be non-blocking.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-28 11:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 14:46 [Qemu-devel] [RFC PATCH 0/3] linux-aio: Convert to coroutines Kevin Wolf
2014-11-26 14:46 ` [Qemu-devel] [RFC PATCH 1/3] qemu-img bench Kevin Wolf
2014-11-28 11:49 ` Stefan Hajnoczi [this message]
2014-11-28 12:19 ` Kevin Wolf
2014-12-01 11:15 ` Stefan Hajnoczi
2014-11-26 14:46 ` [Qemu-devel] [RFC PATCH 2/3] raw-posix: Convert Linux AIO submission to coroutines Kevin Wolf
2014-11-27 9:50 ` Peter Lieven
2014-11-28 12:57 ` Kevin Wolf
2014-11-28 13:44 ` Kevin Wolf
2014-11-28 2:59 ` Ming Lei
2014-11-28 7:33 ` Markus Armbruster
2014-11-28 8:12 ` Ming Lei
2014-11-28 8:59 ` Markus Armbruster
2014-11-28 9:15 ` Ming Lei
2014-11-28 9:44 ` Paolo Bonzini
2014-11-28 10:06 ` Kevin Wolf
2014-11-26 14:46 ` [Qemu-devel] [RFC PATCH 3/3] linux-aio: Don't reenter request coroutine recursively Kevin Wolf
2014-12-04 14:37 ` Kevin Wolf
2014-12-04 15:22 ` Ming Lei
2014-12-04 15:39 ` Kevin Wolf
2014-12-04 15:45 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128114953.GG13631@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).