From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuK3q-0001Ax-Dn for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:50:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuK3h-0005ZE-DG for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:50:06 -0500 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:38573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuK3g-0005Z1-Uu for qemu-devel@nongnu.org; Fri, 28 Nov 2014 06:49:57 -0500 Received: by mail-wi0-f175.google.com with SMTP id l15so18356799wiw.8 for ; Fri, 28 Nov 2014 03:49:56 -0800 (PST) Date: Fri, 28 Nov 2014 11:49:53 +0000 From: Stefan Hajnoczi Message-ID: <20141128114953.GG13631@stefanha-thinkpad.redhat.com> References: <1417013204-30676-1-git-send-email-kwolf@redhat.com> <1417013204-30676-2-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1giRMj6yz/+FOIRq" Content-Disposition: inline In-Reply-To: <1417013204-30676-2-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 1/3] qemu-img bench List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, ming.lei@canonical.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com --1giRMj6yz/+FOIRq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 26, 2014 at 03:46:42PM +0100, Kevin Wolf wrote: > + while (data.n > 0) { > + main_loop_wait(false); > + } Why is this false (non-blocking)? This is why you get the main loop spun warning message. Using true (blocking) seems like the right thing. data.n changes as part of the callback, which is invoked from the main loop. There is no need to be non-blocking. Stefan --1giRMj6yz/+FOIRq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUeGFhAAoJEJykq7OBq3PI7lYH/jLxKt2dhOsCz2fOzquPW2pD M/EEg3jO+AjYTcpEMpgvmTOKl/3px4V7ZU1NWbq8SmJJWFfrhJQz3bk3a8FVTbsS FtYqHvIoSAqK/g4JPhe2QiyGS7aSivNLJc8ZbSqQe3k9N+lmEy2kKlGCvEomC2eK G3vY2PN0aCjQ0NWpjAwU1vkxRCZzRvPcq9RamOSXF82mTY3yktDx3K2V6dwavUt9 cazhgp0Gxb1IEShfxMcDXDZ278aie9hSx1fdhNTAI4bK56dxT2m6lSkG5vSKt52K XQRy5f4s4xi+IxmJj0AFN3GahZkxDndBv7mE3oRkzpxxUsoMZ85C35/RjdaIkpI= =xr5r -----END PGP SIGNATURE----- --1giRMj6yz/+FOIRq--