From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: ming.lei@canonical.com, pl@kamp.de, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/7] coroutine: rewrite pool to avoid mutex
Date: Fri, 28 Nov 2014 17:40:23 +0100 [thread overview]
Message-ID: <20141128164023.GH4035@noname.redhat.com> (raw)
In-Reply-To: <1417183941-26329-6-git-send-email-pbonzini@redhat.com>
Am 28.11.2014 um 15:12 hat Paolo Bonzini geschrieben:
> I still believe we will end with some kind of coroutine bypass scheme
> (even coroutines _do_ allocate an AIOCB, so calling bdrv_aio_readv
> directly can help), but hey it cannot hurt to optimize hot code.
Not sure if speculations about the future belong into commit messages,
but while it may turn out that a bypass is required in the end (I hope
it doesn't), the part about AIOCBs is wrong if you really consistently
use coroutines all the way down from the device to the block driver.
I think Peter picked up all of my patches to actually handle requests
this way (i.e. virtio-blk already creates the coroutine).
Kevin
next prev parent reply other threads:[~2014-11-28 17:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 14:12 [Qemu-devel] [PATCH 0/7] coroutine: optimizations Paolo Bonzini
2014-11-28 14:12 ` [Qemu-devel] [PATCH 1/7] coroutine-ucontext: use __thread Paolo Bonzini
2014-11-28 14:28 ` Peter Maydell
2014-11-28 14:45 ` Markus Armbruster
2014-11-28 15:36 ` Kevin Wolf
2014-11-28 14:12 ` [Qemu-devel] [PATCH 2/7] qemu-thread: add per-thread atexit functions Paolo Bonzini
2014-11-28 14:12 ` [Qemu-devel] [PATCH 3/7] test-coroutine: avoid overflow on 32-bit systems Paolo Bonzini
2014-12-01 1:28 ` Ming Lei
2014-12-01 12:41 ` Paolo Bonzini
2014-12-02 1:20 ` Ming Lei
2014-11-28 14:12 ` [Qemu-devel] [PATCH 4/7] QSLIST: add lock-free operations Paolo Bonzini
2014-11-28 14:12 ` [Qemu-devel] [PATCH 5/7] coroutine: rewrite pool to avoid mutex Paolo Bonzini
2014-11-28 16:40 ` Kevin Wolf [this message]
2014-11-28 17:30 ` Paolo Bonzini
2014-11-28 17:31 ` Paolo Bonzini
2014-11-28 18:34 ` Kevin Wolf
2014-11-28 19:57 ` Paolo Bonzini
2014-11-28 14:12 ` [Qemu-devel] [PATCH 6/7] coroutine: drop qemu_coroutine_adjust_pool_size Paolo Bonzini
2014-11-28 14:12 ` [Qemu-devel] [PATCH 7/7] coroutine: try harder not to delete coroutines Paolo Bonzini
2014-11-28 20:52 ` Peter Lieven
2014-11-29 14:27 ` Paolo Bonzini
2014-11-29 21:28 ` Peter Lieven
2014-11-29 14:28 ` Paolo Bonzini
2014-12-01 5:55 ` [Qemu-devel] [PATCH 0/7] coroutine: optimizations Ming Lei
2014-12-01 7:05 ` Peter Lieven
2014-12-01 7:46 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128164023.GH4035@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).